Bug 224311 – Add test infrastructure for app bound request context string

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kate Cheney]

Add test infrastructure for app bound request context string

[Kate Cheney]

Created attachment 425451 [details]
Patch

[Brent Fulgham]

Comment on attachment 425451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425451&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:60
> +static String contextString(NSURLRequest *) { return { }; }

What this returned a RegistrableDomain?

> LayoutTests/platform/ios-wk2/TestExpectations:1913
> +webkit.org/b/223750 [ Debug ] security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html [ Pass Crash ]

What a weird decision for your text editor to make!

[Alex Christensen]

Comment on attachment 425451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425451&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:697
> +    webPageProxy->appBoundNavigationData([registrableDomain = WebCore::RegistrableDomain::uncheckedCreateFromHost(domain), completionHandler = makeBlockPtr(completionHandler)] (auto&& appBoundData) mutable {

It seems like this SPI should be on WKKWebView instead of WKKWebsiteDataStore if all it does it call a function on the WebView's WebPageProxy.

[Kate Cheney]

(In reply to Brent Fulgham from comment #2)
> Comment on attachment 425451 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425451&action=review
> 
> > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:60
> > +static String contextString(NSURLRequest *) { return { }; }
> 
> What this returned a RegistrableDomain?
> 

That would probably be better, I'll make that change before landing.

> > LayoutTests/platform/ios-wk2/TestExpectations:1913
> > +webkit.org/b/223750 [ Debug ] security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html [ Pass Crash ]
> 
> What a weird decision for your text editor to make!

Oops, didn't notice that, will fix before landing.

[Kate Cheney]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 425451 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425451&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:697
> > +    webPageProxy->appBoundNavigationData([registrableDomain = WebCore::RegistrableDomain::uncheckedCreateFromHost(domain), completionHandler = makeBlockPtr(completionHandler)] (auto&& appBoundData) mutable {
> 
> It seems like this SPI should be on WKKWebView instead of
> WKKWebsiteDataStore if all it does it call a function on the WebView's
> WebPageProxy.

You're right. I was lazy and copied other SPIs in the file, which went through WKWebsiteDataStore to call WebPageProxy functions. Let me see if I can move it to WKWebView before landing.

[Kate Cheney]

Created attachment 425530 [details]
Patch

[Kate Cheney]

(In reply to katherine_cheney from comment #6)
> Created attachment 425530 [details]
> Patch

Awaiting EWS. Moved SPI to WKWebView instead of WKWebsiteDataStore based on Alex's comment.

[EWS]

Committed r275682 (236317@main): <https://commits.webkit.org/236317@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425530 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76424060>