Bug 224301 - Add test to verify _WKCustomHeaderFields is used with HTTP requests
Summary: Add test to verify _WKCustomHeaderFields is used with HTTP requests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-07 12:44 PDT by Alex Christensen
Modified: 2021-04-14 12:46 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.06 KB, patch)
2021-04-07 12:44 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (3.68 KB, patch)
2021-04-07 14:18 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (3.65 KB, patch)
2021-04-07 16:18 PDT, Alex Christensen 		youennf: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-04-07 12:44:06 PDT 
Add test to verify _WKCustomHeaderFields is used with HTTP requests
Comment 1 Alex Christensen 2021-04-07 12:44:43 PDT 
Created attachment 425428 [details]
Patch
Comment 2 Alex Christensen 2021-04-07 14:18:43 PDT 
Created attachment 425438 [details]
Patch
Comment 3 Alex Christensen 2021-04-07 16:18:33 PDT 
Created attachment 425449 [details]
Patch
Comment 4 youenn fablet 2021-04-12 07:55:26 PDT 
Comment on attachment 425449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425449&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1196
> +    NSString *string = [NSString stringWithFormat:@"<script>function bodyloaded(){fetch('%@',{mode:'no-cors'}).then(()=>{alert('loaded')}).catch((e)=>{alert('caught '+e)})}</script><body onload='bodyloaded()'/>", server.request().URL];

Would be interesting to do it with CORS so that:
- injecting this custom header does not trigger preflight requests for all CORS requests
- ensuring preflight requests get that header
Comment 5 Radar WebKit Bug Importer 2021-04-14 12:46:28 PDT 
<rdar://problem/76660315>