Bug 22430 - Only the first WML <card> element should be visible.
Summary: Only the first WML <card> element should be visible.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 20393
  Show dependency treegraph
 
Reported: 2008-11-22 14:21 PST by Nikolas Zimmermann
Modified: 2008-11-24 16:23 PST (History)
0 users

See Also:


Attachments
LayoutTest changes (18.39 KB, patch)
2008-11-22 14:28 PST, Nikolas Zimmermann
staikos: review+
Details | Formatted Diff | Diff
Initial patch (6.48 KB, patch)
2008-11-22 14:29 PST, Nikolas Zimmermann
staikos: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2008-11-22 14:21:37 PST
As the summary says, only the first <card> element in a WML document should be visible. All other card elements are only reachable with a <go> statement within the WML document.
Comment 1 Nikolas Zimmermann 2008-11-22 14:28:57 PST
Created attachment 25381 [details]
LayoutTest changes
Comment 2 Nikolas Zimmermann 2008-11-22 14:29:17 PST
Created attachment 25382 [details]
Initial patch
Comment 3 Eric Seidel (no email) 2008-11-24 12:48:32 PST
This seems lame:
53     if (!page->wmlPageState()->isDeckAccessible()) {
 54         page->goBack();
 55         return;
 56     }
 
Does this mean that a user will click on a link, will be taken to a different "card" or "deck" and then suddenly their browser will go back w/ no explanation?
Comment 4 Nikolas Zimmermann 2008-11-24 13:10:24 PST
(In reply to comment #3)
> This seems lame:
> 53     if (!page->wmlPageState()->isDeckAccessible()) {
>  54         page->goBack();
>  55         return;
>  56     }
> 
> Does this mean that a user will click on a link, will be taken to a different
> "card" or "deck" and then suddenly their browser will go back w/ no
> explanation?
Fixed, I bet this is a testing leftover.
just replaced by // FIXME: Error reporting.
> 

Comment 5 Nikolas Zimmermann 2008-11-24 16:23:37 PST
Landed in r38736.