Bug 224295 - Rename and make the TerminationException a singleton.
Summary: Rename and make the TerminationException a singleton.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-07 11:11 PDT by Mark Lam
Modified: 2021-04-07 17:31 PDT (History)
12 users (show)

See Also:

Attachments
proposed patch. (46.19 KB, patch)
2021-04-07 12:24 PDT, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
proposed patch. (46.26 KB, patch)
2021-04-07 12:52 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-04-07 11:11:54 PDT 
We previously call it the TerminatedExecutionException, which is a mouthful but adds no meaningful information.

We can make it a singleton because the TerminationException is just a VM internal mechanism for implementing the termination of the current execution stack.  It should never be exposed to user JS code, and therefore, there is no value in making it a JS object.  Making it a singleton simplifies the code.
Comment 1 Mark Lam 2021-04-07 12:24:04 PDT 
Created attachment 425424 [details]
proposed patch.
Comment 2 Mark Lam 2021-04-07 12:52:40 PDT 
Created attachment 425429 [details]
proposed patch.
Comment 3 Keith Miller 2021-04-07 15:12:16 PDT 
Comment on attachment 425429 [details]
proposed patch.

r=me the iOS-wk2 failures seem unrelated but maybe worth waiting for confirmation.
Comment 4 Mark Lam 2021-04-07 17:05:44 PDT 
Comment on attachment 425429 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 5 EWS 2021-04-07 17:30:21 PDT 
Committed r275648: <https://commits.webkit.org/r275648>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425429 [details].
Comment 6 Radar WebKit Bug Importer 2021-04-07 17:31:16 PDT 
<rdar://problem/76373832>