Bug 224287 – [iOS][FCR] Use context menus for text input datalist dropdowns

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

...

[Aditya Keerthi]

<rdar://problem/76351317>

[Aditya Keerthi]

Created attachment 425410 [details]
Patch

[Aditya Keerthi]

Created attachment 425412 [details]
Patch

[Aditya Keerthi]

Created attachment 425414 [details]
Patch

[Wenson Hsieh]

Comment on attachment 425414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425414&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9817
> +    return [_dataListSuggestionsControl.getAutoreleased() isShowingSuggestions];

Nit - I think you can remove the `.getAutoreleased()` here.

> Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:48
> +@property (nonatomic, readwrite) BOOL isShowingSuggestions;

Nit - I think you don't need the `readwrite` here, since @property is readwrite by default.

> Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:479
> +        [_suggestionsContextMenuInteraction updateVisibleMenuWithBlock:[self](UIMenu *visibleMenu) -> UIMenu * {

Nit - I think you can just use & in the block capture and omit the `self->` below, since this block is run synchronously.

> Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:594
> +        if (strongSelf)

Nit - you can do `if (auto strongSelf = weakSelf.get())` here.

[Aditya Keerthi]

Created attachment 425580 [details]
Patch for landing

[Aditya Keerthi]

Thanks for the review! Made all the requested changes.

[EWS]

Committed r275760 (236338@main): <https://commits.webkit.org/236338@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425580 [details].