...
<rdar://problem/76351317>
Created attachment 425410 [details] Patch
Created attachment 425412 [details] Patch
Created attachment 425414 [details] Patch
Comment on attachment 425414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425414&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9817 > + return [_dataListSuggestionsControl.getAutoreleased() isShowingSuggestions]; Nit - I think you can remove the `.getAutoreleased()` here. > Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:48 > +@property (nonatomic, readwrite) BOOL isShowingSuggestions; Nit - I think you don't need the `readwrite` here, since @property is readwrite by default. > Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:479 > + [_suggestionsContextMenuInteraction updateVisibleMenuWithBlock:[self](UIMenu *visibleMenu) -> UIMenu * { Nit - I think you can just use & in the block capture and omit the `self->` below, since this block is run synchronously. > Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:594 > + if (strongSelf) Nit - you can do `if (auto strongSelf = weakSelf.get())` here.
Created attachment 425580 [details] Patch for landing
Thanks for the review! Made all the requested changes.
Committed r275760 (236338@main): <https://commits.webkit.org/236338@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425580 [details].