Bug 224270 – [GPU Process] Simplify DisplayList::Iterator part 6: Migrate ItemBufferWritingClient from ItemHandle to a const Variant&

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[GPU Process] Simplify DisplayList::Iterator part 6: Migrate ItemBufferWritingClient from ItemHandle to a const Variant&

[Myles C. Maxfield]

Created attachment 425359 [details]
Patch

[Myles C. Maxfield]

Created attachment 425362 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 425362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425362&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp:607
> +inline bool safeCopyHelper(const T& source, ItemHandle destination)

We can do
using T = typename WTF::RemoveCVAndReference<decltype(a)>::type;
instead of needing a helper.

> Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:324
> +    static RefPtr<WebCore::SharedBuffer> encodeItemOutOfLineHelper(const T& item)

Ditto.

[Myles C. Maxfield]

Created attachment 425471 [details]
Patch

[Wenson Hsieh]

Comment on attachment 425471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425471&action=review

> Source/WebKit/WebKit.xcodeproj/xcshareddata/xcschemes/WebKit.xcscheme:34
> +      buildConfiguration = "Debug"

This change doesn't seem intentional.

[Radar WebKit Bug Importer]

<rdar://problem/76631891>

[Myles C. Maxfield]

Created attachment 428114 [details]
Patch for committing

[Myles C. Maxfield]

Created attachment 428117 [details]
Patch for committing

[EWS]

Committed r277244 (237513@main): <https://commits.webkit.org/237513@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428117 [details].