Bug 224266 - Wasted vector capacity under CSSFontFace::setUnicodeRange()
Summary: Wasted vector capacity under CSSFontFace::setUnicodeRange()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-06 21:10 PDT by Simon Fraser (smfr)
Modified: 2021-04-07 15:48 PDT (History)
10 users (show)

See Also:


Attachments
Patch (1.56 KB, patch)
2021-04-06 21:11 PDT, Simon Fraser (smfr)
drousso: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-04-06 21:10:35 PDT
Wasted vector capacity under CSSFontFace::setUnicodeRange()
Comment 1 Simon Fraser (smfr) 2021-04-06 21:11:06 PDT
Created attachment 425352 [details]
Patch
Comment 2 Devin Rousso 2021-04-07 09:54:30 PDT
Comment on attachment 425352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425352&action=review

r=me

> Source/WebCore/css/CSSFontFace.cpp:274
>      auto& list = downcast<CSSValueList>(unicodeRange);

What about using `map` instead?
```
auto ranges = WTF::map(downcast<CSSValueList>(unicodeRange), [] (auto& rangeValue) -> UnicodeRange {
    return { range.from(), range.to() };
});
```
Comment 3 Simon Fraser (smfr) 2021-04-07 15:33:58 PDT
(In reply to Devin Rousso from comment #2)
> Comment on attachment 425352 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425352&action=review
> 
> r=me
> 
> > Source/WebCore/css/CSSFontFace.cpp:274
> >      auto& list = downcast<CSSValueList>(unicodeRange);
> 
> What about using `map` instead?
> ```
> auto ranges = WTF::map(downcast<CSSValueList>(unicodeRange), [] (auto&
> rangeValue) -> UnicodeRange {
>     return { range.from(), range.to() };
> });
> ```

CSSValueList doesn't quite allow map() to work.
Comment 4 Simon Fraser (smfr) 2021-04-07 15:47:36 PDT
https://trac.webkit.org/changeset/275638/webkit
Comment 5 Radar WebKit Bug Importer 2021-04-07 15:48:33 PDT
<rdar://problem/76369477>