Bug 224266 – Wasted vector capacity under CSSFontFace::setUnicodeRange()

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Simon Fraser (smfr)]

Wasted vector capacity under CSSFontFace::setUnicodeRange()

[Simon Fraser (smfr)]

Created attachment 425352 [details]
Patch

[Devin Rousso]

Comment on attachment 425352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425352&action=review

r=me

> Source/WebCore/css/CSSFontFace.cpp:274
>      auto& list = downcast<CSSValueList>(unicodeRange);

What about using `map` instead?
```
auto ranges = WTF::map(downcast<CSSValueList>(unicodeRange), [] (auto& rangeValue) -> UnicodeRange {
    return { range.from(), range.to() };
});
```

[Simon Fraser (smfr)]

(In reply to Devin Rousso from comment #2)
> Comment on attachment 425352 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425352&action=review
> 
> r=me
> 
> > Source/WebCore/css/CSSFontFace.cpp:274
> >      auto& list = downcast<CSSValueList>(unicodeRange);
> 
> What about using `map` instead?
> ```
> auto ranges = WTF::map(downcast<CSSValueList>(unicodeRange), [] (auto&
> rangeValue) -> UnicodeRange {
>     return { range.from(), range.to() };
> });
> ```

CSSValueList doesn't quite allow map() to work.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/275638/webkit

[Radar WebKit Bug Importer]

<rdar://problem/76369477>