Bug 224256 - [ macOS wk2 ] webrtc/libwebrtc/release-while-creating-offer.html is a flakey text failure
Summary: [ macOS wk2 ] webrtc/libwebrtc/release-while-creating-offer.html is a flakey ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-06 18:04 PDT by Robert Jenner
Modified: 2021-04-12 06:52 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.10 KB, patch)
2021-04-08 02:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (5.08 KB, patch)
2021-04-12 01:07 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (3.97 KB, patch)
2021-04-12 05:54 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2021-04-06 18:04:00 PDT 
webrtc/libwebrtc/release-while-creating-offer.html

is a flakey text failure on macOS wk2. 

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=webrtc%2Flibwebrtc%2Frelease-while-creating-offer.html

TEXT DIFF:
--- /Volumes/Data/worker/bigsur-debug-tests-wk2/build/layout-test-results/webrtc/libwebrtc/release-while-creating-offer-expected.txt
+++ /Volumes/Data/worker/bigsur-debug-tests-wk2/build/layout-test-results/webrtc/libwebrtc/release-while-creating-offer-actual.txt
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Candidate must not have both null sdpMid and sdpMLineIndex
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Radar WebKit Bug Importer 2021-04-06 18:04:32 PDT 
<rdar://problem/76296126>
Comment 2 Robert Jenner 2021-04-06 18:14:31 PDT 
Looks like the test has been flakey flailing close to when it started running on BigSur, with the first failure at r272143. I was able to reproduce the failure at BigSur Debug ToT using the following test:

run-webkit-tests webrtc/libwebrtc/release-while-creating-offer.html --debug --iterations 1000 -f
Comment 3 Robert Jenner 2021-04-06 18:20:08 PDT 
Updated test expectations to Pass Failure here, while test is under review:

https://trac.webkit.org/changeset/275582/webkit
Comment 4 youenn fablet 2021-04-08 02:47:43 PDT 
Created attachment 425490 [details]
Patch
Comment 5 youenn fablet 2021-04-12 01:07:34 PDT 
Created attachment 425723 [details]
Patch
Comment 6 Eric Carlson 2021-04-12 05:14:24 PDT 
Comment on attachment 425723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425723&action=review

> Source/WTF/wtf/PlatformHave.h:-951
> -
> -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000 && __MAC_OS_X_VERSION_MAX_ALLOWED >= 110300) \
> -    || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 140500) \
> -    || (PLATFORM(APPLETV) && __TV_OS_VERSION_MAX_ALLOWED >= 140500) \
> -    || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED >= 70400)
> -#define HAVE_VM_FLAGS_PERMANENT 1
> -#endif
> -
> -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000) \
> -    || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) \
> -    || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 80000) \
> -    || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 150000)
> -#define HAVE_CFNETWORK_NSURLSESSION_ATTRIBUTED_BUNDLE_IDENTIFIER 1
> -#endif

I don't think you meant to include this
Comment 7 youenn fablet 2021-04-12 05:54:54 PDT 
Created attachment 425738 [details]
Patch for landing
Comment 8 youenn fablet 2021-04-12 05:55:08 PDT 
> I don't think you meant to include this

Right, this is fixed in patch for landing!
Comment 9 EWS 2021-04-12 06:52:09 PDT 
Committed r275822 (236392@main): <https://commits.webkit.org/236392@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425738 [details].