Bug 224239 – [WebXR] Introduce XRDeviceIdentifier and XRDeviceInfo to be used to communicate device info

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ada Chan]

[WebXR] Introduce XRDeviceIdentifier and XRDeviceInfo to be used to communicate device info

[Ada Chan]

Created attachment 425298 [details]
Patch

[Tim Horton]

Comment on attachment 425298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425298&action=review

> Source/WebKit/Shared/Cocoa/XRDeviceInfo.mm:41
> +    encoder << static_cast<uint64_t>(features.size());
> +    for (auto feature : features)
> +        encoder << feature;

Odd, WebKit2's ArgumentCoders.h totally has a VectorArgumentCoder. Do you need this custom implementation?

[Ada Chan]

(In reply to Tim Horton from comment #2)
> Comment on attachment 425298 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425298&action=review
> 
> > Source/WebKit/Shared/Cocoa/XRDeviceInfo.mm:41
> > +    encoder << static_cast<uint64_t>(features.size());
> > +    for (auto feature : features)
> > +        encoder << feature;
> 
> Odd, WebKit2's ArgumentCoders.h totally has a VectorArgumentCoder. Do you
> need this custom implementation?

Ah, I did not realize that. I'll update the patch.

[Ada Chan]

Created attachment 425306 [details]
Patch

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 425306 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 425306 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[Ada Chan]

Created attachment 425443 [details]
Patch

[EWS]

Committed r275640: <https://commits.webkit.org/r275640>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425443 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76369842>

[Wenson Hsieh]

Reopening to attach new patch.

[Wenson Hsieh]

Created attachment 425520 [details]
Unreviewed build fix

[Ada Chan]

(In reply to Wenson Hsieh from comment #11)
> Created attachment 425520 [details]
> Unreviewed build fix

Thanks Wenson!

[EWS]

Committed r275663 (236299@main): <https://commits.webkit.org/236299@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425520 [details].