NEW 224231
Compiler warnings that need to be fixed
https://bugs.webkit.org/show_bug.cgi?id=224231
Summary Compiler warnings that need to be fixed
Eleni Maria Stea
Reported 2021-04-06 03:01:30 PDT
--- Description --- There are some compiler warnings that need to be fixed: /WebKit/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: WTFLogAlways("SQLiteIDBBackingStore::databasesSizeForDirectory filePath='%s', database='%s', size=%" PRIu64, file.utf8().data(), databaseName.utf8().data(), fileSize); last argument should be long long int. WebKit/Source/WebCore/inspector/InspectorOverlay.cpp: FloatLine lineBetweenColumnBottoms = { columnStartLine.end(), previousColumnEndLine.end() }; is not used. Functions: WebCore::FloatSize WebCore::expectedSizeForLayoutLabel(WTF::String, WebCore::InspectorOverlay::LabelArrowDirection, float) in /Source/WebCore/inspector/InspectorOverlay.cpp and WebCore::Color WebCore::CSSPropertyParserHelpers::mixColorComponents(WebCore::CSSPropertyParserHelpers::ColorMixColorSpace, const WebCore::CSSPropertyParserHelpers::ColorMixComponent&, const WebCore::CSSPropertyParserHelpers::ColorMixComponent&) in Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp don't have a return type.
Attachments
Proposed patch for 224231 (5.09 KB, patch)
2021-04-06 03:50 PDT, Eleni Maria Stea
no flags
Patch (2.63 KB, patch)
2021-04-27 05:36 PDT, Eleni Maria Stea
estea: review?
Eleni Maria Stea
Comment 1 2021-04-06 03:50:13 PDT
Created attachment 425260 [details] Proposed patch for 224231 proposed patch, fixes compiler warnings
Eleni Maria Stea
Comment 2 2021-04-06 07:54:00 PDT
broke the Apple build, working on v2
Joseph Pecoraro
Comment 3 2021-04-08 11:10:36 PDT
Comment on attachment 425260 [details] Proposed patch for 224231 View in context: https://bugs.webkit.org/attachment.cgi?id=425260&action=review > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1278 > + WTFLogAlways("SQLiteIDBBackingStore::databasesSizeForDirectory filePath='%s', database='%s', size=%l" PRIu64, file.utf8().data(), databaseName.utf8().data(), fileSize); Here the `PRIu64` is the format string value. It is like `%ull`. Perhaps an include is missing for your particular port?
Radar WebKit Bug Importer
Comment 4 2021-04-13 03:02:12 PDT
Eleni Maria Stea
Comment 5 2021-04-27 05:36:41 PDT
Eleni Maria Stea
Comment 6 2021-04-27 05:41:07 PDT
(In reply to Joseph Pecoraro from comment #3) > Comment on attachment 425260 [details] > Proposed patch for 224231 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=425260&action=review > > > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1278 > > + WTFLogAlways("SQLiteIDBBackingStore::databasesSizeForDirectory filePath='%s', database='%s', size=%l" PRIu64, file.utf8().data(), databaseName.utf8().data(), fileSize); > > Here the `PRIu64` is the format string value. It is like `%ull`. Perhaps an > include is missing for your particular port? You must be right, I've changed my patch to fix the other two warnings, and I'm going to investigate this further. Thank you!
Note You need to log in before you can comment on or make changes to this bug.