Shrink some IndexedDB-related classes
Created attachment 425237 [details] Patch
Comment on attachment 425237 [details] Patch r=me iOS-wk2 EWS failures seem unrelated
Committed r275547: <https://commits.webkit.org/r275547> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425237 [details].
<rdar://problem/76282457>
Comment on attachment 425237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425237&action=review > Source/WebCore/Modules/indexeddb/IndexedDB.h:62 > +enum class VersionNullness : uint8_t { Why not bool? > Source/WebCore/Modules/indexeddb/IndexedDB.h:78 > +enum class ObjectStoreRecordType : uint8_t { Why not bool? > Source/WebCore/Modules/indexeddb/IndexedDB.h:101 > +enum class GetAllType : uint8_t { Why not bool?
(In reply to Darin Adler from comment #5) > Comment on attachment 425237 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=425237&action=review > > > Source/WebCore/Modules/indexeddb/IndexedDB.h:62 > > +enum class VersionNullness : uint8_t { > > Why not bool? Do we prefer bool over uint8_t? Both are common in the code. If so, we should put this in the coding guidelines and update the style checker.
(In reply to Simon Fraser (smfr) from comment #6) > Do we prefer bool over uint8_t? Both are common in the code. If so, we > should put this in the coding guidelines and update the style checker. I certainly do for things that are obviously "Yes/No". And I prefer them for anything where there are only two states. But maybe we don’t have consensus. Makes sense that both are common. Having no type at all is also common.