Bug 224217 - Remove RepaintLayoutRectsMap
Summary: Remove RepaintLayoutRectsMap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-05 17:18 PDT by Simon Fraser (smfr)
Modified: 2021-04-07 16:08 PDT (History)
11 users (show)

See Also:


Attachments
Patch (20.33 KB, patch)
2021-04-05 17:25 PDT, Simon Fraser (smfr)
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-04-05 17:18:29 PDT
Remove RepaintLayoutRectsMap
Comment 1 Simon Fraser (smfr) 2021-04-05 17:25:01 PDT
Created attachment 425226 [details]
Patch
Comment 2 zalan 2021-04-05 20:34:13 PDT
Comment on attachment 425226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425226&action=review

great change.

> Source/WebCore/rendering/ComplexLineLayout.cpp:1328
> +        if (!layoutContext().needsFullRepaint() && m_flow.hasSelfPaintingLayer() && m_flow.layerRepaintRects()) {

isn't m_flow.hasSelfPaintingLayer() redundant here (though maybe it provides some information about the type of content (backed by a layer) we are dealing here with).

> Source/WebCore/rendering/RenderLayer.h:224
> +        return WTF::nullopt;

return { }; ?
Comment 3 Simon Fraser (smfr) 2021-04-07 16:07:25 PDT
https://trac.webkit.org/changeset/275641/webkit
Comment 4 Radar WebKit Bug Importer 2021-04-07 16:08:24 PDT
<rdar://problem/76370395>