Bug 224213 - Make sure the Frame always gets destroyed on the main thread
Summary: Make sure the Frame always gets destroyed on the main thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-05 16:00 PDT by Chris Dumez
Modified: 2021-04-05 19:16 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2021-04-05 16:02 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-04-05 16:00:12 PDT 
Make sure the Frame always gets destroyed on the main thread.

Since http://trac.webkit.org/changeset/181791, Frame is ThreadSafeRefCounted and captured on other threads. We should make sure the Frame is always destroyed on the main thread though, since it is a main thread object and we hold WeakPtrs to it in many places.
Comment 1 Chris Dumez 2021-04-05 16:00:43 PDT 
<rdar://75131946>
Comment 2 Chris Dumez 2021-04-05 16:02:02 PDT 
Created attachment 425220 [details]
Patch
Comment 3 EWS 2021-04-05 19:16:35 PDT 
Committed r275475: <https://commits.webkit.org/r275475>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425220 [details].