Bug 224202 - Replace the Optional metadata of ImageSource by a single OptionSet and the underlying metadata
Summary: Replace the Optional metadata of ImageSource by a single OptionSet and the un...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-05 13:51 PDT by Said Abou-Hallawa
Modified: 2021-04-06 16:37 PDT (History)
3 users (show)

See Also:

Attachments
Patch (19.76 KB, patch)
2021-04-05 15:20 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (19.76 KB, patch)
2021-04-05 15:42 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (19.76 KB, patch)
2021-04-05 15:58 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (20.28 KB, patch)
2021-04-06 13:40 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2021-04-05 13:51:08 PDT 
Encapsulating the metadata in a Optionals adds extra memory cost.
Comment 1 Said Abou-Hallawa 2021-04-05 15:20:28 PDT 
Created attachment 425213 [details]
Patch
Comment 2 Tim Horton 2021-04-05 15:35:36 PDT 
cahced!
Comment 3 Simon Fraser (smfr) 2021-04-05 15:37:27 PDT 
Comment on attachment 425213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425213&action=review

> Source/WebCore/platform/graphics/ImageSource.h:226
> +    OptionSet<MetadataType> m_cahcedMetadata;

"cahced"
Comment 4 Said Abou-Hallawa 2021-04-05 15:42:33 PDT 
Created attachment 425216 [details]
Patch
Comment 5 Said Abou-Hallawa 2021-04-05 15:58:44 PDT 
Created attachment 425219 [details]
Patch
Comment 6 Said Abou-Hallawa 2021-04-06 13:40:56 PDT 
Created attachment 425320 [details]
Patch
Comment 7 EWS 2021-04-06 16:36:32 PDT 
Committed r275570: <https://commits.webkit.org/r275570>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425320 [details].
Comment 8 Radar WebKit Bug Importer 2021-04-06 16:37:17 PDT 
<rdar://problem/76290352>