Bug 224201 - Web Inspector: Grid overlay areas appear offset from their actual areas when the grid container has a border set
Summary: Web Inspector: Grid overlay areas appear offset from their actual areas when ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-05 13:15 PDT by Patrick Angle
Modified: 2021-04-06 10:19 PDT (History)
6 users (show)

See Also:

Attachments
Screenshot of Issue (78.28 KB, image/png)
2021-04-05 13:50 PDT, Patrick Angle 		no flags Details
Screenshot of Patch v1.0 (79.18 KB, image/png)
2021-04-05 13:50 PDT, Patrick Angle 		no flags Details
Patch v1.0 (2.47 KB, patch)
2021-04-05 14:00 PDT, Patrick Angle 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-04-05 13:15:06 PDT 
There is a discrepancy in how the two axes are handled inside InspectorOverlay::buildGridOverlay where areas are not always taking the border of the grid container into account. Grid lines are correctly aligned in these situations, but the area borders are not.
Comment 1 Patrick Angle 2021-04-05 13:50:17 PDT 
Created attachment 425200 [details]
Screenshot of Issue
Comment 2 Patrick Angle 2021-04-05 13:50:38 PDT 
Created attachment 425201 [details]
Screenshot of Patch v1.0
Comment 3 Patrick Angle 2021-04-05 14:00:47 PDT 
Created attachment 425202 [details]
Patch v1.0
Comment 4 BJ Burg 2021-04-06 09:23:11 PDT 
Comment on attachment 425202 [details]
Patch v1.0

r=me, good catch
Comment 5 Patrick Angle 2021-04-06 10:02:59 PDT 
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html has a history of flaky failure on mac-AS-debug-wk2 unrelated to this patch.
Comment 6 EWS 2021-04-06 10:18:57 PDT 
Committed r275529: <https://commits.webkit.org/r275529>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425202 [details].
Comment 7 Radar WebKit Bug Importer 2021-04-06 10:19:14 PDT 
<rdar://problem/76272770>