Bug 224200 - Web Inspector: Grid overlay line numbers should not include implicit tracks in negative line number calculations.
Summary: Web Inspector: Grid overlay line numbers should not include implicit tracks i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on: 224199
Blocks:
  Show dependency tree / graph
 
Reported: 2021-04-05 13:12 PDT by Patrick Angle
Modified: 2021-04-06 16:14 PDT (History)
7 users (show)

See Also:

Attachments
Patch v1.0 (3.73 KB, patch)
2021-04-06 13:48 PDT, Patrick Angle 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-04-05 13:12:36 PDT 
The negative line numbers should only be counting from the last explicit track in each direction. Currently they are being shown as counting from the last track, including implicit tracks.
Comment 1 Radar WebKit Bug Importer 2021-04-06 10:20:18 PDT 
<rdar://problem/76272817>
Comment 2 Patrick Angle 2021-04-06 13:48:39 PDT 
Created attachment 425321 [details]
Patch v1.0
Comment 3 BJ Burg 2021-04-06 13:52:56 PDT 
Comment on attachment 425321 [details]
Patch v1.0

r=me
Comment 4 EWS 2021-04-06 15:09:15 PDT 
Committed r275558: <https://commits.webkit.org/r275558>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425321 [details].