Bug 224190 – set-webkit-configuration should print current settings

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

set-webkit-configuration should print current settings when it's run so there's no guessing about the current configuration settings.

No arguments:

$ ./Tools/Scripts/set-webkit-configuration 
Usage: set-webkit-configuration [options]
  --32-bit                           Set the default architecture to 32-bit
  --64-bit                           Set the default architecture to 64-bit
  --[no-]asan                        Enable or disable clang address sanitizer
  --[no-]tsan                        Enable or disable clang thread sanitizer
  --[no-]ubsan                       Enable or disable clang undefined behavior sanitizer
  --[no-]coverage                    Enable or disable LLVM Source-based Code Coverage
  --force-optimization-level=<level> Optimization level: O3, O2, O1, O0, Os, Ofast, Og, or none
  --lto-mode=<mode>                  Set LTO mode: full, thin, or none
  --debug                            Set the default configuration to debug
  --release                          Set the default configuration to release
  --reset                            Reset configurations

Current settings: Configuration:Release Arch:x86_64

Using --reset:

$ ./Tools/Scripts/set-webkit-configuration --reset
Current settings: Configuration:Release Arch:x86_64

Some switches:

$ ./Tools/Scripts/set-webkit-configuration --release --asan --ubsan
Current settings: Configuration:Release Arch:x86_64 ASan UBSan

Some other switches:

$ ./Tools/Scripts/set-webkit-configuration --debug
Current settings: Configuration:Debug Arch:x86_64

[David Kilzer (:ddkilzer)]

Created attachment 425164 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Just realized this might affect EWS since set-webkit-configuration will not print out its current config when run, so added a few folks to the CC list.

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #2)
> Just realized this might affect EWS since set-webkit-configuration will not
> print out its current config when run, so added a few folks to the CC list.

The jsc-mips-tests failure has nothing to do with this change:

OSError: [Errno 28] No space left on device: '/home/buildbot/igalia-jsc32-mipsel-ews-02/JSC-MIPSEL-32bits-Tests-EWS/build/WebKitBuild/Release'

[Mark Lam]

Comment on attachment 425164 [details]
Patch v1

r=me

[EWS]

Committed r275534: <https://commits.webkit.org/r275534>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425164 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76274997>