Bug 224189 - [iOS] Prevent background blur when presenting date/time pickers
Summary: [iOS] Prevent background blur when presenting date/time pickers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-05 09:38 PDT by Aditya Keerthi
Modified: 2021-04-06 13:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2021-04-05 09:39 PDT, Aditya Keerthi 		wenson_hsieh: review+
wenson_hsieh: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (2.72 KB, patch)
2021-04-05 12:08 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-04-05 09:38:05 PDT 
...
Comment 1 Aditya Keerthi 2021-04-05 09:38:18 PDT 
<rdar://problem/76220352>
Comment 2 Aditya Keerthi 2021-04-05 09:39:35 PDT 
Created attachment 425159 [details]
Patch
Comment 3 Aditya Keerthi 2021-04-05 09:42:08 PDT 
Thanks for the review!

Will commit once the tree is open.
Comment 4 Aakash Jain 2021-04-05 12:00:23 PDT 
Comment on attachment 425159 [details]
Patch

From https://ews-build.webkit.org/#/builders/53/builds/11856:
WKDateTimeInputControl.mm:162:11: error: property 'preferredBackgroundEffects' not found on object of type '_UIContextMenuStyle *'
Comment 5 Wenson Hsieh 2021-04-05 12:02:49 PDT 
Comment on attachment 425159 [details]
Patch

Restoring the r+ (and adding cq- instead).

The build fix here is straightforward (we probably just need to update UIKitSPI.h)
Comment 6 Aditya Keerthi 2021-04-05 12:08:39 PDT 
Created attachment 425184 [details]
Patch for landing
Comment 7 Aakash Jain 2021-04-05 12:26:53 PDT 
I did the r- so that rest of EWS bots do not process that patch (since they have  backlog of patches to process currently). Since there is a new patch uploaded, we can also mark the older patch as obsolete, so that all the EWS queue do not need to process that patch.

EWS skips r- and obsolete patches.
Comment 8 Wenson Hsieh 2021-04-05 12:28:42 PDT 
Comment on attachment 425159 [details]
Patch

(In reply to Aakash Jain from comment #7)
> I did the r- so that rest of EWS bots do not process that patch (since they
> have  backlog of patches to process currently). Since there is a new patch
> uploaded, we can also mark the older patch as obsolete, so that all the EWS
> queue do not need to process that patch.
> 
> EWS skips r- and obsolete patches.

I see. In that case, we could mark the patch as obsolete.
Comment 9 EWS 2021-04-06 10:54:15 PDT 
Committed r275532: <https://commits.webkit.org/r275532>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425184 [details].