Bug 224183 - [METAL ANGLE] Stencil only formats being used as the depth attachment.
Summary: [METAL ANGLE] Stencil only formats being used as the depth attachment.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-05 07:04 PDT by John Cunningham
Modified: 2021-04-05 19:16 PDT (History)
9 users (show)

See Also:


Attachments
Patch (11.94 KB, patch)
2021-04-05 07:11 PDT, John Cunningham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Cunningham 2021-04-05 07:04:14 PDT
Fixes a couple of issues found when using Google Earth, specifically zooming in towards Earth. 

1. Stencil only states previously only worked if combined as depth stencil, stencil only formats such as GL_STENCIL_INDEX8 were being incorrectly set as the Metal depth attachment. 

2. WebGL contexts issuing many draws and updating a lot of uniforms would have the command encoder be invalidated before they were finished rendering. Previously the command encoder was restarted from an empty state, this change fixes that such that the command buffer and encoder is completely invalidated and the next draw call will set up where the previous command encoder finished. 

3. 'Angle_out' transformation was being applied to the result of Angle_swizzle_ref, which may cause issues due to the different address space. I'm not exactly sure what's intended here, but the change looks reasonable and fixes Google Earth. Let the tests run and make sure this doesn't regress something else.
Comment 1 John Cunningham 2021-04-05 07:11:18 PDT
Created attachment 425149 [details]
Patch
Comment 2 EWS Watchlist 2021-04-05 09:14:31 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Jon Lee 2021-04-05 09:39:47 PDT
rdar://76157243
Comment 4 EWS 2021-04-05 18:17:51 PDT
commit-queue failed to commit attachment 425149 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 5 Maciej Stachowiak 2021-04-05 18:27:45 PDT
Comment on attachment 425149 [details]
Patch

Reflagging for CQ. The CQ error seems bogus.
Comment 6 EWS 2021-04-05 19:16:58 PDT
Committed r275476: <https://commits.webkit.org/r275476>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425149 [details].