Bug 224140 - [macOS] Add MediaSessionCoordinator API test
Summary: [macOS] Add MediaSessionCoordinator API test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-02 16:48 PDT by Eric Carlson
Modified: 2021-04-06 12:06 PDT (History)
6 users (show)

See Also:


Attachments
WIP patch (72.17 KB, patch)
2021-04-02 16:56 PDT, Eric Carlson
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP patch (72.27 KB, patch)
2021-04-02 17:10 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
WIP patch (72.31 KB, patch)
2021-04-03 06:39 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
WIP, with state change tests (78.28 KB, patch)
2021-04-03 11:02 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch for landing (73.25 KB, patch)
2021-04-06 10:07 PDT, Eric Carlson
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (73.26 KB, patch)
2021-04-06 10:16 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2021-04-02 16:48:58 PDT
Add basic MediaSessionCoordinator API test
Comment 1 Radar WebKit Bug Importer 2021-04-02 16:49:22 PDT
<rdar://problem/76171173>
Comment 2 Eric Carlson 2021-04-02 16:56:48 PDT
Created attachment 425064 [details]
WIP patch
Comment 3 Eric Carlson 2021-04-02 17:10:50 PDT
Created attachment 425068 [details]
WIP patch
Comment 4 Eric Carlson 2021-04-03 06:39:42 PDT
Created attachment 425094 [details]
WIP patch
Comment 5 Eric Carlson 2021-04-03 11:02:36 PDT
Created attachment 425101 [details]
WIP, with state change tests
Comment 6 Jer Noble 2021-04-04 11:25:30 PDT
Comment on attachment 425101 [details]
WIP, with state change tests

View in context: https://bugs.webkit.org/attachment.cgi?id=425101&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:68
> -void WebKit::NetworkSessionCocoa::removeNetworkWebsiteData(WallTime, CompletionHandler<void()>&& completionHandler) { completionHandler(); }
> +void WebKit::NetworkSessionCocoa:: (WallTime, CompletionHandler<void()>&& completionHandler) { completionHandler(); }

This looks accidental.
Comment 7 Eric Carlson 2021-04-06 10:07:03 PDT
Created attachment 425293 [details]
Patch for landing
Comment 8 Eric Carlson 2021-04-06 10:16:32 PDT
Created attachment 425297 [details]
Patch for landing
Comment 9 EWS 2021-04-06 12:06:58 PDT
Committed r275537: <https://commits.webkit.org/r275537>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425297 [details].