WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
224124
Allow the WebAuthn UI to inform users about BiometryLockout
https://bugs.webkit.org/show_bug.cgi?id=224124
Summary
Allow the WebAuthn UI to inform users about BiometryLockout
Jiewen Tan
Reported
2021-04-02 12:48:20 PDT
Allow the WebAuthn UI to inform users about BiometryLockout.
Attachments
Patch
(1.67 KB, patch)
2021-04-02 12:53 PDT
,
Jiewen Tan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jiewen Tan
Comment 1
2021-04-02 12:49:01 PDT
rdar://74815938
Jiewen Tan
Comment 2
2021-04-02 12:53:29 PDT
Created
attachment 425043
[details]
Patch
Garrett Davidson
Comment 3
2021-04-02 13:45:39 PDT
How did you test this?
Brent Fulgham
Comment 4
2021-04-02 17:14:19 PDT
Comment on
attachment 425043
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=425043&action=review
The test failures on iOS-wk2 don't seem related to this change. r=me
> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49 > + if ((!result || error) && error.code != LAErrorBiometryLockout) {
Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover?
Jiewen Tan
Comment 5
2021-04-02 19:19:06 PDT
Comment on
attachment 425043
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=425043&action=review
Thanks Brent for r+ this patch.
>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49 >> + if ((!result || error) && error.code != LAErrorBiometryLockout) { > > Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover?
We just need to let the operation continue. The UI itself has a way to detect the LAErrorBiometryLockout and then inform the user.
Garrett Davidson
Comment 6
2021-04-05 13:29:06 PDT
Comment on
attachment 425043
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=425043&action=review
>>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49 >>> + if ((!result || error) && error.code != LAErrorBiometryLockout) { >> >> Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover? > > We just need to let the operation continue. The UI itself has a way to detect the LAErrorBiometryLockout and then inform the user.
Yep, the UI should take care of it, but we’ve never been able to hit that code path before. Jiewen, can you test this change and send us a bug before landing if that isn’t going to work?
EWS
Comment 7
2021-04-05 17:08:08 PDT
commit-queue failed to commit
attachment 425043
[details]
to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 8
2021-04-05 21:49:50 PDT
Committed
r275492
: <
https://commits.webkit.org/r275492
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 425043
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug