Bug 224124 – Allow the WebAuthn UI to inform users about BiometryLockout

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jiewen Tan]

Allow the WebAuthn UI to inform users about BiometryLockout.

[Jiewen Tan]

rdar://74815938

[Jiewen Tan]

Created attachment 425043 [details]
Patch

[Garrett Davidson]

How did you test this?

[Brent Fulgham]

Comment on attachment 425043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review

The test failures on iOS-wk2 don't seem related to this change. r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49
> +    if ((!result || error) && error.code != LAErrorBiometryLockout) {

Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover?

[Jiewen Tan]

Comment on attachment 425043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49
>> +    if ((!result || error) && error.code != LAErrorBiometryLockout) {
> 
> Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover?

We just need to let the operation continue. The UI itself has a way to detect the LAErrorBiometryLockout and then inform the user.

[Garrett Davidson]

Comment on attachment 425043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review

>>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49
>>> +    if ((!result || error) && error.code != LAErrorBiometryLockout) {
>> 
>> Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover?
> 
> We just need to let the operation continue. The UI itself has a way to detect the LAErrorBiometryLockout and then inform the user.

Yep, the UI should take care of it, but we’ve never been able to hit that code path before. Jiewen, can you test this change and send us a bug before landing if that isn’t going to work?

[EWS]

commit-queue failed to commit attachment 425043 [details] to WebKit repository. To retry, please set cq+ flag again.

[EWS]

Committed r275492: <https://commits.webkit.org/r275492>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425043 [details].