Bug 224124 - Allow the WebAuthn UI to inform users about BiometryLockout
Summary: Allow the WebAuthn UI to inform users about BiometryLockout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-02 12:48 PDT by Jiewen Tan
Modified: 2021-04-05 21:49 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2021-04-02 12:53 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2021-04-02 12:48:20 PDT 
Allow the WebAuthn UI to inform users about BiometryLockout.
Comment 1 Jiewen Tan 2021-04-02 12:49:01 PDT 
rdar://74815938
Comment 2 Jiewen Tan 2021-04-02 12:53:29 PDT 
Created attachment 425043 [details]
Patch
Comment 3 Garrett Davidson 2021-04-02 13:45:39 PDT 
How did you test this?
Comment 4 Brent Fulgham 2021-04-02 17:14:19 PDT 
Comment on attachment 425043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review

The test failures on iOS-wk2 don't seem related to this change. r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49
> +    if ((!result || error) && error.code != LAErrorBiometryLockout) {

Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover?
Comment 5 Jiewen Tan 2021-04-02 19:19:06 PDT 
Comment on attachment 425043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49
>> +    if ((!result || error) && error.code != LAErrorBiometryLockout) {
> 
> Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover?

We just need to let the operation continue. The UI itself has a way to detect the LAErrorBiometryLockout and then inform the user.
Comment 6 Garrett Davidson 2021-04-05 13:29:06 PDT 
Comment on attachment 425043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review

>>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49
>>> +    if ((!result || error) && error.code != LAErrorBiometryLockout) {
>> 
>> Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover?
> 
> We just need to let the operation continue. The UI itself has a way to detect the LAErrorBiometryLockout and then inform the user.

Yep, the UI should take care of it, but we’ve never been able to hit that code path before. Jiewen, can you test this change and send us a bug before landing if that isn’t going to work?
Comment 7 EWS 2021-04-05 17:08:08 PDT 
commit-queue failed to commit attachment 425043 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 8 EWS 2021-04-05 21:49:50 PDT 
Committed r275492: <https://commits.webkit.org/r275492>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425043 [details].