WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
22412
Coding style: spacing in .h files
https://bugs.webkit.org/show_bug.cgi?id=22412
Summary
Coding style: spacing in .h files
Dmitry Titov
Reported
2008-11-21 13:36:53 PST
1. shifted stuff inside 'namespace' right. 2. added '// namespace Foo' and '// FooBar_h' at the closing brackets of namespaces and ifdefs.
Attachments
proposed patch
(146.68 KB, patch)
2008-11-21 13:40 PST
,
Dmitry Titov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dmitry Titov
Comment 1
2008-11-21 13:40:55 PST
Created
attachment 25362
[details]
proposed patch
Dmitry Titov
Comment 2
2008-11-21 13:43:33 PST
Comment got auto-filled, it's not for build-webkit, it's just a patch :-)
Dmitry Titov
Comment 3
2008-11-25 15:40:13 PST
Comment on
attachment 25362
[details]
proposed patch Realized it's hard to review (even though the change is to just indent code inside 'namespace' scope in header files) - the diff tool shows it in a scary way. Will perhaps do it later in much smaller pieces...
Dmitry Titov
Comment 4
2009-02-11 13:27:28 PST
Not much use to keep the open bug on this cleanup, will create more when actual work is done.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug