Bug 22412 - Coding style: spacing in .h files
Summary: Coding style: spacing in .h files
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-21 13:36 PST by Dmitry Titov
Modified: 2009-02-11 13:27 PST (History)
0 users

See Also:

Attachments
proposed patch (146.68 KB, patch)
2008-11-21 13:40 PST, Dmitry Titov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2008-11-21 13:36:53 PST 
1. shifted stuff inside 'namespace' right.
2. added '// namespace Foo' and '// FooBar_h' at the closing brackets of namespaces and ifdefs.
Comment 1 Dmitry Titov 2008-11-21 13:40:55 PST 
Created attachment 25362 [details]
proposed patch
Comment 2 Dmitry Titov 2008-11-21 13:43:33 PST 
Comment got auto-filled, it's not for build-webkit, it's just a patch :-)
Comment 3 Dmitry Titov 2008-11-25 15:40:13 PST 
Comment on attachment 25362 [details]
proposed patch 

Realized it's hard to review (even though the change is to just indent code inside 'namespace' scope in header files) - the diff tool shows it in a scary way. Will perhaps do it later in much smaller pieces...
Comment 4 Dmitry Titov 2009-02-11 13:27:28 PST 
Not much use to keep the open bug on this cleanup, will create more when actual work is done.