Bug 224099 - [WPE] Enable Cog's GTK4 backend
Summary: [WPE] Enable Cog's GTK4 backend
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
Depends on:
Reported: 2021-04-02 02:26 PDT by Philippe Normand
Modified: 2021-04-06 07:58 PDT (History)
9 users (show)

See Also:

Patch (2.16 KB, patch)
2021-04-02 02:31 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (3.95 KB, patch)
2021-04-06 07:07 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-04-02 02:26:51 PDT
Comment 1 Philippe Normand 2021-04-02 02:31:10 PDT
Created attachment 424999 [details]
Comment 2 Adrian Perez 2021-04-05 05:38:06 PDT
Comment on attachment 424999 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=424999&action=review

> Tools/Scripts/webkitpy/port/wpe.py:155
> +                args = ['-P', 'gtk4'] + args

If somebody passes “--platform=foo”, then the final command line will end
up with “--platform=foo -P gtk4”. It would be good to add a check here for
that. For example, from the top of my mind (that is, untested):

  has_platform_arg = any((a == "-P" or a.startswith("--platform=") for a in args))
  if not has_platform_arg:
      args.insert(0, "--platform=gtk4")
Comment 3 Adrian Perez 2021-04-05 05:39:12 PDT
FWIW, other than the missing check for “--platform=”, I agree that
it's nicer to have Cog use GTK4 by default while Cog does not have
support for detecting what to use :)
Comment 4 Philippe Normand 2021-04-06 07:07:58 PDT
Created attachment 425273 [details]
Comment 5 EWS 2021-04-06 07:58:41 PDT
Committed r275517: <https://commits.webkit.org/r275517>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425273 [details].