.
Created attachment 424999 [details] Patch
Comment on attachment 424999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424999&action=review > Tools/Scripts/webkitpy/port/wpe.py:155 > + args = ['-P', 'gtk4'] + args If somebody passes “--platform=foo”, then the final command line will end up with “--platform=foo -P gtk4”. It would be good to add a check here for that. For example, from the top of my mind (that is, untested): has_platform_arg = any((a == "-P" or a.startswith("--platform=") for a in args)) if not has_platform_arg: args.insert(0, "--platform=gtk4")
FWIW, other than the missing check for “--platform=”, I agree that it's nicer to have Cog use GTK4 by default while Cog does not have support for detecting what to use :)
Created attachment 425273 [details] Patch
Committed r275517: <https://commits.webkit.org/r275517> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425273 [details].