Bug 224095 - Allow wheel events to trigger high frequency DisplayLinks
Summary: Allow wheel events to trigger high frequency DisplayLinks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-01 22:42 PDT by Simon Fraser (smfr)
Modified: 2021-04-02 16:05 PDT (History)
3 users (show)

See Also:

Attachments
Patch (18.89 KB, patch)
2021-04-01 22:48 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (18.92 KB, patch)
2021-04-01 23:06 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (27.98 KB, patch)
2021-04-02 12:07 PDT, Simon Fraser (smfr) 		sam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-04-01 22:42:08 PDT 
Allow wheel events to trigger high frequency DisplayLinks
Comment 1 Simon Fraser (smfr) 2021-04-01 22:48:49 PDT 
Created attachment 424990 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-04-01 22:49:18 PDT 
<rdar://problem/76138455>
Comment 3 Simon Fraser (smfr) 2021-04-01 23:06:09 PDT 
Created attachment 424991 [details]
Patch
Comment 4 Simon Fraser (smfr) 2021-04-02 12:07:57 PDT 
Created attachment 425037 [details]
Patch
Comment 5 Sam Weinig 2021-04-02 14:20:08 PDT 
Comment on attachment 425037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425037&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:824
> +void WebProcessPool::setDisplayLinkForDisplayWantsFullSpeedUpdates(IPC::Connection& connection, WebCore::PlatformDisplayID displayID, bool wantsFullSpeedUpdates)

I do not think this is right place for this, but it seems that ship has sailed since that is where the display links are.
Comment 6 EWS 2021-04-02 16:02:01 PDT 
Tools/Scripts/svn-apply failed to apply attachment 425037 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 7 Simon Fraser (smfr) 2021-04-02 16:05:39 PDT 
https://trac.webkit.org/changeset/275440/webkit