(Need one of these fixes for https://bugs.webkit.org/show_bug.cgi?id=223150#c14, but I'll fix some of the other build errors too)
Created attachment 424976 [details]
Created attachment 424977 [details]
Created attachment 424982 [details]
Committed r275422: <https://commits.webkit.org/r275422>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 424982 [details].
Comment on attachment 424982 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=424982&action=review
> + * dom/EventContext.h:
> + * dom/FocusOptions.h:
The ones that involve adding an include to a header are worth "struggling with" a little. Sometimes we can rearrange instead of adding the includes. Not worth it if it’s a .cpp file, but adding a header to a header can definitely contribute to overall project build time slowdown and blot.
> + * workers/service/server/SWScriptStorage.h:
> + * Modules/mediastream/RTCDataChannelRemoteSource.h:
Reopening to attach new patch.
Created attachment 425128 [details]
That's a good point, thanks -- I'll keep that in mind for the next one. This follow-up patch should be an improvement. An include of Document.h was added to FocusOptions.h just for a single enum (SelectionRestorationMode). I split this enum out into a separate file so we don't have to do that anymore.
Created attachment 425130 [details]
Comment on attachment 425130 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=425130&action=review
> +enum class SelectionRestorationMode : uint8_t;
We normally put enum forward declarations in their own separate paragraph after classes. Sort of “alphabetical order” with enum after class.
Created attachment 425170 [details]
Committed r275527: <https://commits.webkit.org/r275527>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 425170 [details].