RESOLVED FIXED 224088
Make sure service workers use a ScriptSourceCode backed by file-mapped memory when possible 
https://bugs.webkit.org/show_bug.cgi?id=224088
Summary Make sure service workers use a ScriptSourceCode backed by file-mapped memory...
Chris Dumez
Reported 2021-04-01 17:42:08 PDT
Make sure service workers use a ScriptSourceCode backed by file-mapped memory whenever possible. This saves dirty memory in the WebProcess.
Attachments
WIP Patch (36.25 KB, patch)
2021-04-01 17:48 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP Patch (33.92 KB, patch)
2021-04-02 12:14 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP Patch (36.71 KB, patch)
2021-04-02 13:18 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP Patch (36.70 KB, patch)
2021-04-02 14:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (37.53 KB, patch)
2021-04-02 16:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (58.01 KB, patch)
2021-04-02 17:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-04-01 17:48:02 PDT
Created attachment 424969 [details] WIP Patch Needs polish but with this patch, warm memory usage on my service worker test case with ~200MB of scripts, the WebContent memory usage goes from 231MB to ~23MB. The patch does not take care of the cold case yet.
Chris Dumez
Comment 2 2021-04-02 12:14:09 PDT
Created attachment 425039 [details] WIP Patch
Chris Dumez
Comment 3 2021-04-02 13:18:57 PDT
Created attachment 425046 [details] WIP Patch The patch should now work in both the warm and cold cases. However, I am waiting for the dependency patch to land before I rebase & clean it up.
Chris Dumez
Comment 4 2021-04-02 14:32:54 PDT
Created attachment 425055 [details] WIP Patch
Chris Dumez
Comment 5 2021-04-02 16:11:48 PDT
Created attachment 425063 [details] WIP Patch
Chris Dumez
Comment 6 2021-04-02 17:16:21 PDT
Created attachment 425071 [details] Patch
Yusuke Suzuki
Comment 7 2021-04-05 11:38:08 PDT
Comment on attachment 425071 [details] Patch r=me
EWS
Comment 8 2021-04-05 18:05:30 PDT
Committed r275465: <https://commits.webkit.org/r275465> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425071 [details].
Radar WebKit Bug Importer
Comment 9 2021-04-05 18:07:07 PDT
<rdar://problem/76245819>
Note You need to log in before you can comment on or make changes to this bug.