Bug 224081 - Add a macro to help staging logDiagnosticMessageWithDomain in Safari
Summary: Add a macro to help staging logDiagnosticMessageWithDomain in Safari
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-01 15:03 PDT by Said Abou-Hallawa
Modified: 2021-04-01 22:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2021-04-01 16:12 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2021-04-01 15:03:20 PDT 
This macro will tell whether logDiagnosticMessageWithDomain and _WKDiagnosticLoggingDomain are defined or not. So checking macro will allow building the webkit clients with or without r275103.
Comment 1 Said Abou-Hallawa 2021-04-01 16:12:46 PDT 
Created attachment 424959 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-04-01 16:39:29 PDT 
<rdar://problem/76128509>
Comment 3 Wenson Hsieh 2021-04-01 17:07:45 PDT 
Comment on attachment 424959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424959&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:30
> +#define HAS_DIAGNOSTIC_LOGGING_DOMAIN

I think it's common practice to wrap these kinds of `#define`s in `#ifndef/#endif` (though I admittedly can't find many existing examples in WebKit to use as reference :/)
Comment 4 EWS 2021-04-01 22:00:38 PDT 
Committed r275404: <https://commits.webkit.org/r275404>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424959 [details].