RESOLVED FIXED 224079
[check-webkit-style] Check python files in LayoutTests 
https://bugs.webkit.org/show_bug.cgi?id=224079
Summary [check-webkit-style] Check python files in LayoutTests
Jonathan Bedard
Reported 2021-04-01 14:48:18 PDT
We should run the style checker over python files in LayoutTests.
Attachments
Patch (2.29 KB, patch)
2021-04-01 14:52 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-04-01 14:48:58 PDT
<rdar://problem/76122813>
Jonathan Bedard
Comment 2 2021-04-01 14:52:46 PDT
Created attachment 424951 [details] Patch
dewei_zhu
Comment 3 2021-04-02 12:06:03 PDT
Comment on attachment 424951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424951&action=review > Tools/Scripts/webkitpy/style/checker.py:640 > - elif basename in _NEVER_SKIPPED_FILES: > - return False > + for suffix in _NEVER_SKIPPED_FILES: > + if basename.endswith(suffix): > + return False I saw some potential behavior change: `A-TestExpectations` will not return False and now it will?
Jonathan Bedard
Comment 4 2021-04-02 13:38:29 PDT
Comment on attachment 424951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424951&action=review >> Tools/Scripts/webkitpy/style/checker.py:640 >> + return False > > I saw some potential behavior change: `A-TestExpectations` will not return False and now it will? Yes, although that may not be a bad thing. First, there isn't anything like "*TestExpectations" in LayoutTests. But more importantly, if we do end up picking up a file we don't expect to, we just end up running the style checker more aggressively than we intended to, which is unlikely to be harmful
dewei_zhu
Comment 5 2021-04-02 14:24:26 PDT
Comment on attachment 424951 [details] Patch r=me
EWS
Comment 6 2021-04-02 15:20:27 PDT
Committed r275444: <https://commits.webkit.org/r275444> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424951 [details].
Note You need to log in before you can comment on or make changes to this bug.