RESOLVED FIXED 224065
REGRESSION(r274724): JITCage trampoline needs to be adjusted 
https://bugs.webkit.org/show_bug.cgi?id=224065
Summary REGRESSION(r274724): JITCage trampoline needs to be adjusted
Yusuke Suzuki
Reported 2021-04-01 12:17:58 PDT
REGRESSION(r274724): JITCage trampoline needs to be adjusted
Attachments
Patch (9.19 KB, patch)
2021-04-01 12:21 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (10.59 KB, patch)
2021-04-01 12:50 PDT, Yusuke Suzuki 		saam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-04-01 12:21:15 PDT
Created attachment 424928 [details] Patch
Yusuke Suzuki
Comment 2 2021-04-01 12:50:55 PDT
Created attachment 424943 [details] Patch
Sam Weinig
Comment 3 2021-04-01 13:02:39 PDT
Sorry about that. Is there anything you can think to do so that we can do to make this a compile time error in the future? Somehow statically asserting that vmEntryCustomGetter/vmEntryCustomSetter match GetValueFuncWithPtr/PutValueFuncWithPtr?
Yusuke Suzuki
Comment 4 2021-04-01 13:06:44 PDT
(In reply to Sam Weinig from comment #3) > Sorry about that. > > Is there anything you can think to do so that we can do to make this a > compile time error in the future? Somehow statically asserting that > vmEntryCustomGetter/vmEntryCustomSetter match > GetValueFuncWithPtr/PutValueFuncWithPtr? That sounds good! I'll add `static_assert` which checks # of parameter matches with PutValueFuncWithPtr etc. as a first step :)
Yusuke Suzuki
Comment 5 2021-04-01 16:07:03 PDT
Committed r275392 (236056@main): <https://commits.webkit.org/236056@main>
Yusuke Suzuki
Comment 6 2021-04-01 16:07:31 PDT
<rdar://problem/75871161>
Radar WebKit Bug Importer
Comment 7 2021-04-01 16:08:14 PDT
<rdar://problem/76126947>
Sam Weinig
Comment 8 2021-04-02 10:42:20 PDT
(In reply to Yusuke Suzuki from comment #4) > (In reply to Sam Weinig from comment #3) > > Sorry about that. > > > > Is there anything you can think to do so that we can do to make this a > > compile time error in the future? Somehow statically asserting that > > vmEntryCustomGetter/vmEntryCustomSetter match > > GetValueFuncWithPtr/PutValueFuncWithPtr? > > That sounds good! I'll add `static_assert` which checks # of parameter > matches with PutValueFuncWithPtr etc. as a first step :) Very nice! Thanks!
Note You need to log in before you can comment on or make changes to this bug.