Bug 224065 - REGRESSION(r274724): JITCage trampoline needs to be adjusted
Summary: REGRESSION(r274724): JITCage trampoline needs to be adjusted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-01 12:17 PDT by Yusuke Suzuki
Modified: 2021-04-02 10:42 PDT (History)
8 users (show)

See Also:


Attachments
Patch (9.19 KB, patch)
2021-04-01 12:21 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (10.59 KB, patch)
2021-04-01 12:50 PDT, Yusuke Suzuki
sbarati: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-04-01 12:17:58 PDT
REGRESSION(r274724): JITCage trampoline needs to be adjusted
Comment 1 Yusuke Suzuki 2021-04-01 12:21:15 PDT
Created attachment 424928 [details]
Patch
Comment 2 Yusuke Suzuki 2021-04-01 12:50:55 PDT
Created attachment 424943 [details]
Patch
Comment 3 Sam Weinig 2021-04-01 13:02:39 PDT
Sorry about that. 

Is there anything you can think to do so that we can do to make this a compile time error in the future? Somehow statically asserting that vmEntryCustomGetter/vmEntryCustomSetter match GetValueFuncWithPtr/PutValueFuncWithPtr?
Comment 4 Yusuke Suzuki 2021-04-01 13:06:44 PDT
(In reply to Sam Weinig from comment #3)
> Sorry about that. 
> 
> Is there anything you can think to do so that we can do to make this a
> compile time error in the future? Somehow statically asserting that
> vmEntryCustomGetter/vmEntryCustomSetter match
> GetValueFuncWithPtr/PutValueFuncWithPtr?

That sounds good! I'll add `static_assert` which checks # of parameter matches with PutValueFuncWithPtr etc. as a first step :)
Comment 5 Yusuke Suzuki 2021-04-01 16:07:03 PDT
Committed r275392 (236056@main): <https://commits.webkit.org/236056@main>
Comment 6 Yusuke Suzuki 2021-04-01 16:07:31 PDT
<rdar://problem/75871161>
Comment 7 Radar WebKit Bug Importer 2021-04-01 16:08:14 PDT
<rdar://problem/76126947>
Comment 8 Sam Weinig 2021-04-02 10:42:20 PDT
(In reply to Yusuke Suzuki from comment #4)
> (In reply to Sam Weinig from comment #3)
> > Sorry about that. 
> > 
> > Is there anything you can think to do so that we can do to make this a
> > compile time error in the future? Somehow statically asserting that
> > vmEntryCustomGetter/vmEntryCustomSetter match
> > GetValueFuncWithPtr/PutValueFuncWithPtr?
> 
> That sounds good! I'll add `static_assert` which checks # of parameter
> matches with PutValueFuncWithPtr etc. as a first step :)

Very nice! Thanks!