RESOLVED FIXED 224060
Remove use of ENABLE from API header 
https://bugs.webkit.org/show_bug.cgi?id=224060
Summary Remove use of ENABLE from API header
Tadeu Zagallo
Reported 2021-04-01 11:49:16 PDT
<rdar://76111678>
Attachments
Patch (2.96 KB, patch)
2021-04-01 12:00 PDT, Tadeu Zagallo 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (2.99 KB, patch)
2021-04-01 12:09 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2021-04-01 12:00:14 PDT
Created attachment 424924 [details] Patch
Saam Barati
Comment 2 2021-04-01 12:01:18 PDT
Comment on attachment 424924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424924&action=review > Source/JavaScriptCore/API/JSVirtualMachine.mm:288 > +#if ENABLE(DFG_JIT) don't you want to return 0 in an #else?
Mark Lam
Comment 3 2021-04-01 12:01:33 PDT
Comment on attachment 424924 [details] Patch r=me
Mark Lam
Comment 4 2021-04-01 12:02:22 PDT
Comment on attachment 424924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424924&action=review >> Source/JavaScriptCore/API/JSVirtualMachine.mm:288 >> +#if ENABLE(DFG_JIT) > > don't you want to return 0 in an #else? Yeah, I was about to say that too. Missed it the first time I read this.
Tadeu Zagallo
Comment 5 2021-04-01 12:08:36 PDT
Comment on attachment 424924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424924&action=review >>> Source/JavaScriptCore/API/JSVirtualMachine.mm:288 >>> +#if ENABLE(DFG_JIT) >> >> don't you want to return 0 in an #else? > > Yeah, I was about to say that too. Missed it the first time I read this. Oops, good catch, thanks
Tadeu Zagallo
Comment 6 2021-04-01 12:09:10 PDT
Created attachment 424926 [details] Patch for landing
EWS
Comment 7 2021-04-01 13:02:55 PDT
Committed r275374: <https://commits.webkit.org/r275374> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424926 [details].
Note You need to log in before you can comment on or make changes to this bug.