Bug 224060 - Remove use of ENABLE from API header
Summary: Remove use of ENABLE from API header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-01 11:49 PDT by Tadeu Zagallo
Modified: 2021-04-01 13:02 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2021-04-01 12:00 PDT, Tadeu Zagallo 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (2.99 KB, patch)
2021-04-01 12:09 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2021-04-01 11:49:16 PDT 
<rdar://76111678>
Comment 1 Tadeu Zagallo 2021-04-01 12:00:14 PDT 
Created attachment 424924 [details]
Patch
Comment 2 Saam Barati 2021-04-01 12:01:18 PDT 
Comment on attachment 424924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424924&action=review

> Source/JavaScriptCore/API/JSVirtualMachine.mm:288
> +#if ENABLE(DFG_JIT)

don't  you want to return 0 in an  #else?
Comment 3 Mark Lam 2021-04-01 12:01:33 PDT 
Comment on attachment 424924 [details]
Patch

r=me
Comment 4 Mark Lam 2021-04-01 12:02:22 PDT 
Comment on attachment 424924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424924&action=review

>> Source/JavaScriptCore/API/JSVirtualMachine.mm:288
>> +#if ENABLE(DFG_JIT)
> 
> don't  you want to return 0 in an  #else?

Yeah, I was about to say that too.  Missed it the first time I read this.
Comment 5 Tadeu Zagallo 2021-04-01 12:08:36 PDT 
Comment on attachment 424924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424924&action=review

>>> Source/JavaScriptCore/API/JSVirtualMachine.mm:288
>>> +#if ENABLE(DFG_JIT)
>> 
>> don't  you want to return 0 in an  #else?
> 
> Yeah, I was about to say that too.  Missed it the first time I read this.

Oops, good catch, thanks
Comment 6 Tadeu Zagallo 2021-04-01 12:09:10 PDT 
Created attachment 424926 [details]
Patch for landing
Comment 7 EWS 2021-04-01 13:02:55 PDT 
Committed r275374: <https://commits.webkit.org/r275374>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424926 [details].