Bug 224057 - Expand on shouldComputeLogicalWidthFromAspectRatioAndInsets return logic
Summary: Expand on shouldComputeLogicalWidthFromAspectRatioAndInsets return logic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-01 11:01 PDT by zalan
Modified: 2021-04-01 21:03 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.46 KB, patch)
2021-04-01 11:04 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.64 KB, patch)
2021-04-01 19:48 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-04-01 11:01:28 PDT 
trying to replace
"return style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto());"
with something easier to parse.
Comment 1 zalan 2021-04-01 11:04:19 PDT 
Created attachment 424913 [details]
Patch
Comment 2 Rob Buis 2021-04-01 13:56:05 PDT 
Comment on attachment 424913 [details]
Patch

This looks good to me once the commit message is fixed. Thanks for working on this :)
Comment 3 zalan 2021-04-01 19:48:54 PDT 
Created attachment 424980 [details]
Patch
Comment 4 zalan 2021-04-01 20:48:14 PDT 
(In reply to Rob Buis from comment #2)
> Comment on attachment 424913 [details]
> Patch
> 
> This looks good to me once the commit message is fixed. 
Thanks for the review!

>Thanks for working on this :)
I am trying to figure out an infinite recursion bug and I realized I should have involved myself more during the initial patch reviews. It's all new to me now.
Comment 5 EWS 2021-04-01 21:02:10 PDT 
Committed r275402: <https://commits.webkit.org/r275402>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424980 [details].
Comment 6 Radar WebKit Bug Importer 2021-04-01 21:03:15 PDT 
<rdar://problem/76136339>