Bug 224044 – Cleanup shouldComputeLogicalWidthFromAspectRatio and shouldComputeLogicalWidthFromAspectRatioAndInsets

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

turn
if (foo)
  return true;
return false;

into
return !foo;

[zalan]

Created attachment 424886 [details]
Patch

[Antti Koivisto]

Comment on attachment 424886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424886&action=review

> Source/WebCore/rendering/RenderBox.cpp:5130
> +    return style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto());

I'd probably split this into multiple returns.

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 424886 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424886&action=review
> 
> > Source/WebCore/rendering/RenderBox.cpp:5130
> > +    return style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto());
> 
> I'd probably split this into multiple returns.
Good idea. I am still trying to understand what this logic is in reference to. will do in a separate patch.

[zalan]

(In reply to zalan from comment #0)
> turn
> if (foo)
>   return true;
> return false;
> 
> into
> return !foo;
should read "return foo;"

[EWS]

Committed r275357: <https://commits.webkit.org/r275357>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424886 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76103365>