turn if (foo) return true; return false; into return !foo;
Created attachment 424886 [details] Patch
Comment on attachment 424886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424886&action=review > Source/WebCore/rendering/RenderBox.cpp:5130 > + return style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto()); I'd probably split this into multiple returns.
(In reply to Antti Koivisto from comment #2) > Comment on attachment 424886 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424886&action=review > > > Source/WebCore/rendering/RenderBox.cpp:5130 > > + return style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto()); > > I'd probably split this into multiple returns. Good idea. I am still trying to understand what this logic is in reference to. will do in a separate patch.
(In reply to zalan from comment #0) > turn > if (foo) > return true; > return false; > > into > return !foo; should read "return foo;"
Committed r275357: <https://commits.webkit.org/r275357> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424886 [details].
<rdar://problem/76103365>