Fix some missing exception checks in HTMLMediaElement methods.

[Mark Lam]

rdar://69573092

[Mark Lam]

Created attachment 424870 [details]
proposed patch.

[Eric Carlson]

Comment on attachment 424870 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=424870&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:7277
> +        auto clearExceptionAndReturnFalse = [&] () -> bool {
> +            scope.clearException();
> +            return false;
> +        };

I think we might as well report the exception unless you know of a reason not to. Failing setup here will change the page behavior, so logging something may help us diagnose user problems.

[Mark Lam]

Thanks for the review.

(In reply to Eric Carlson from comment #2)
> Comment on attachment 424870 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424870&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:7277
> > +        auto clearExceptionAndReturnFalse = [&] () -> bool {
> > +            scope.clearException();
> > +            return false;
> > +        };
> 
> I think we might as well report the exception unless you know of a reason
> not to. Failing setup here will change the page behavior, so logging
> something may help us diagnose user problems.

I've applied this change.

Landed in r275361: <http://trac.webkit.org/r275361>.