Bug 224023 – Feed preferred frames per second back to the UI process for each DisplayRefreshMonitor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Simon Fraser (smfr)]

Feed preferred frames per second back to the UI process for each DisplayRefreshMonitor

[Simon Fraser (smfr)]

Created attachment 424830 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/76074444>

[Sam Weinig]

Comment on attachment 424830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424830&action=review

> Source/WebCore/ChangeLog:9
> +        so move from a model where has DisplayRefreshMonitor setPreferredFramesPerSecond()

This sentence doesn't quite parse.

> Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp:94
> +    auto addResult = m_clients.add(&client);
> +    if (addResult.isNewEntry) {

In what cases is addClient() called multiple times with the same client?

> Source/WebKit/UIProcess/WebProcessProxy.h:81
>  using PlatformDisplayID = uint32_t;
> +using FramesPerSecond = unsigned;

Sort please.

[Simon Fraser (smfr)]

(In reply to Sam Weinig from comment #3)

> 
> > Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp:94
> > +    auto addResult = m_clients.add(&client);
> > +    if (addResult.isNewEntry) {
> 
> In what cases is addClient() called multiple times with the same client?

Don't know but it seems fine to only do the work when new clients are added.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/275345/webkit