Bug 224020 - Remove misleading FIXME comment in RenderBox::shouldComputeLogicalWidthFromAspectRatioAndInsets
Summary: Remove misleading FIXME comment in RenderBox::shouldComputeLogicalWidthFromAs...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-31 14:47 PDT by zalan
Modified: 2021-03-31 15:37 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2021-03-31 14:50 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-03-31 14:47:03 PDT 
RenderStyle is not supposed to contain any logic like this (or any logic for that matter).
Comment 1 zalan 2021-03-31 14:50:17 PDT 
Created attachment 424822 [details]
Patch
Comment 2 EWS 2021-03-31 15:36:23 PDT 
Committed r275312: <https://commits.webkit.org/r275312>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424822 [details].
Comment 3 Radar WebKit Bug Importer 2021-03-31 15:37:25 PDT 
<rdar://problem/76074652>