Using abort() for fatal failures is bad for at least two reasons: 1) We don't get a crash log. 2) It's impolite to silently close an application on failure, as if it was never running. We already use CRASH everywhere, except for FastMalloc and one place in Collector. We could consider taking measures against using abort (or just define it to CRASH), but I'm not sure how much that would help in practice.
Created attachment 25352 [details] proposed patch
Comment on attachment 25352 [details] proposed patch r=me
Created attachment 25358 [details] abort() if crashing failed Mitz reminds that CRASH() is not 100% reliable. Added an abort() call after it.
Committed revision 38665.
Reverted in r38672 - this was somehow breaking this code in Interpreter.cpp: #define ADD_OPCODE_ID(id) m_opcodeIDTable.add(&&id, id); FOR_EACH_OPCODE_ID(ADD_OPCODE_ID); #undef ADD_OPCODE_ID
Comment on attachment 25358 [details] abort() if crashing failed Clearing review flag.
Created attachment 25360 [details] take three
Committed revision 38673.