Bug 224010 - Web Inspector: Autocomplete experimental CSS Color values (hwb, lch, lab, color-mix, color-contrast)
Summary: Web Inspector: Autocomplete experimental CSS Color values (hwb, lch, lab, col...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-31 12:27 PDT by Nikita Vasilyev
Modified: 2021-03-31 15:32 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.66 KB, patch)
2021-03-31 12:30 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2021-03-31 12:55 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2021-03-31 12:27:01 PDT 
Web Inspector should show completions for these when the corresponding experimental settings are enabled.
Comment 1 Radar WebKit Bug Importer 2021-03-31 12:27:11 PDT 
<rdar://problem/76065217>
Comment 2 Nikita Vasilyev 2021-03-31 12:30:35 PDT 
Created attachment 424801 [details]
Patch
Comment 3 Joseph Pecoraro 2021-03-31 12:44:37 PDT 
Comment on attachment 424801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424801&action=review

> Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:166
> +WI.CSSKeywordCompletions.getExperimentalProperties = function(properties) {

Style: Put the `{` on the next line?

> Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:169
> +        if (CSS.supports(test))

The `CSS.supports` is neat, but why not do it all time?

You could be on a macOS system that doesn't support the syntax and inspecting an iOS target that does support it. In that case we'd probably still want completion to work. So might as well do it all the time.
Comment 4 Nikita Vasilyev 2021-03-31 12:55:17 PDT 
Created attachment 424808 [details]
Patch
Comment 5 BJ Burg 2021-03-31 15:10:00 PDT 
Comment on attachment 424808 [details]
Patch

r=me
Comment 6 EWS 2021-03-31 15:31:58 PDT 
Committed r275310: <https://commits.webkit.org/r275310>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424808 [details].