Bug 224008 - [webkitscmpy] Improve git-svn-id regex
Summary: [webkitscmpy] Improve git-svn-id regex
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
Keywords: InRadar
Depends on:
Reported: 2021-03-31 11:35 PDT by Jonathan Bedard
Modified: 2021-04-01 04:36 PDT (History)
2 users (show)

See Also:

[fast-cq] Patch (8.09 KB, patch)
2021-03-31 11:41 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
[fast-cq] Patch for landing (7.51 KB, patch)
2021-04-01 04:29 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-03-31 11:35:46 PDT
A git-svn-id is only valid if it is at the beginning of a new line, otherwise, the regex may be matching the git-svn-id of a cherry-picked commit contained inside a given commit. Additionally, it turns out that our mock Git code was generating incorrect git-svn-id lines, but we didn't notice because stripping off the first 4 characters results in "svn-id", which seemed correct enough that we enshrined it in our unit tests.
Comment 1 Radar WebKit Bug Importer 2021-03-31 11:35:58 PDT
Comment 2 Jonathan Bedard 2021-03-31 11:41:57 PDT
Created attachment 424794 [details]
[fast-cq] Patch
Comment 3 Aakash Jain 2021-03-31 15:27:12 PDT
Comment on attachment 424794 [details]
[fast-cq] Patch

Comment 4 EWS 2021-04-01 04:21:23 PDT
Tools/Scripts/svn-apply failed to apply attachment 424794 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 5 Aakash Jain 2021-04-01 04:29:52 PDT
Created attachment 424884 [details]
[fast-cq] Patch for landing

Resolved conflict by updating version in setup.py and __init__.py
Comment 6 EWS 2021-04-01 04:36:24 PDT
Committed r275353 (?): <https://commits.webkit.org/r275353>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424884 [details].