Bug 223999 - Make use of NSURLSessionWebSocket.sendCloseCode if available
Summary: Make use of NSURLSessionWebSocket.sendCloseCode if available
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-31 08:25 PDT by youenn fablet
Modified: 2021-03-31 11:13 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2021-03-31 08:29 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.70 KB, patch)
2021-03-31 10:12 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-03-31 08:25:53 PDT 
Make use of NSURLSessionWebSocket.sendCloseCode if available
Comment 1 youenn fablet 2021-03-31 08:29:37 PDT 
Created attachment 424772 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-03-31 09:01:51 PDT 
<rdar://problem/76055268>
Comment 3 Sam Weinig 2021-03-31 09:27:42 PDT 
Comment on attachment 424772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424772&action=review

> Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm:42
> +@interface NSURLSessionWebSocketTask (SPI)
> +// Send close frame but do not cancel the task
> +- (void)_sendCloseCode:(NSURLSessionWebSocketCloseCode)closeCode reason:(NSData *)reason;
> +@end

Please put SPI declarations into the CFNetworkSPI.h header.
Comment 4 Alex Christensen 2021-03-31 10:12:09 PDT 
Created attachment 424785 [details]
Patch
Comment 5 EWS 2021-03-31 11:13:08 PDT 
Committed r275294: <https://commits.webkit.org/r275294>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424785 [details].