Bug 223985 – [Cocoa] REGRESSION(r272999): User-installed fonts no longer work in Mail

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Cocoa] REGRESSION(r272999): User-installed fonts no longer work in Mail

[Myles C. Maxfield]

Created attachment 424738 [details]
Needs a test

[Myles C. Maxfield]

<rdar://problem/75975210>

[Myles C. Maxfield]

Created attachment 424743 [details]
Patch

[Myles C. Maxfield]

Created attachment 424873 [details]
Patch

[Per Arne Vollan]

Comment on attachment 424873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424873&action=review

Thanks! R=me.

> Source/WebKit/WebProcess/WebPage/WebPage.h:-2275
> -
> -#if HAVE(STATIC_FONT_REGISTRY)
> -    RefPtr<SandboxExtension> m_fontExtension;
> -#endif

You may also be able to remove the font extension member in WebProcess, since you can consume the extension permanently.

[Myles C. Maxfield]

(In reply to Per Arne Vollan from comment #5)
> Comment on attachment 424873 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424873&action=review
> 
> Thanks! R=me.
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.h:-2275
> > -
> > -#if HAVE(STATIC_FONT_REGISTRY)
> > -    RefPtr<SandboxExtension> m_fontExtension;
> > -#endif
> 
> You may also be able to remove the font extension member in WebProcess,
> since you can consume the extension permanently.

SandboxExtension's destructor actually explicitly makes sure that this doesn't happen.

[EWS]

Committed r275371: <https://commits.webkit.org/r275371>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424873 [details].