Bug 223985 - [Cocoa] REGRESSION(r272999): User-installed fonts no longer work in Mail
Summary: [Cocoa] REGRESSION(r272999): User-installed fonts no longer work in Mail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-31 00:06 PDT by Myles C. Maxfield
Modified: 2021-04-01 11:50 PDT (History)
6 users (show)

See Also:

Attachments
Needs a test (2.60 KB, patch)
2021-03-31 00:07 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (5.14 KB, patch)
2021-03-31 01:11 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (9.80 KB, patch)
2021-03-31 23:08 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-03-31 00:06:06 PDT 
[Cocoa] REGRESSION(r272999): User-installed fonts no longer work in Mail
Comment 1 Myles C. Maxfield 2021-03-31 00:07:20 PDT 
Created attachment 424738 [details]
Needs a test
Comment 2 Myles C. Maxfield 2021-03-31 00:08:05 PDT 
<rdar://problem/75975210>
Comment 3 Myles C. Maxfield 2021-03-31 01:11:09 PDT 
Created attachment 424743 [details]
Patch
Comment 4 Myles C. Maxfield 2021-03-31 23:08:35 PDT 
Created attachment 424873 [details]
Patch
Comment 5 Per Arne Vollan 2021-04-01 10:03:36 PDT 
Comment on attachment 424873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424873&action=review

Thanks! R=me.

> Source/WebKit/WebProcess/WebPage/WebPage.h:-2275
> -
> -#if HAVE(STATIC_FONT_REGISTRY)
> -    RefPtr<SandboxExtension> m_fontExtension;
> -#endif

You may also be able to remove the font extension member in WebProcess, since you can consume the extension permanently.
Comment 6 Myles C. Maxfield 2021-04-01 11:14:35 PDT 
(In reply to Per Arne Vollan from comment #5)
> Comment on attachment 424873 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424873&action=review
> 
> Thanks! R=me.
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.h:-2275
> > -
> > -#if HAVE(STATIC_FONT_REGISTRY)
> > -    RefPtr<SandboxExtension> m_fontExtension;
> > -#endif
> 
> You may also be able to remove the font extension member in WebProcess,
> since you can consume the extension permanently.

SandboxExtension's destructor actually explicitly makes sure that this doesn't happen.
Comment 7 EWS 2021-04-01 11:50:29 PDT 
Committed r275371: <https://commits.webkit.org/r275371>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424873 [details].