Bug 223984 - Assertions in DisplayUpdate when dragging WebView windows between screens with different refresh rates
Summary: Assertions in DisplayUpdate when dragging WebView windows between screens wit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-30 21:29 PDT by Simon Fraser (smfr)
Modified: 2021-03-31 14:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (19.56 KB, patch)
2021-03-30 21:38 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (19.57 KB, patch)
2021-03-30 21:56 PDT, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-03-30 21:29:02 PDT 
Assertions in DisplayUpdate when dragging WebView windows between screens with different refresh rates
Comment 1 Simon Fraser (smfr) 2021-03-30 21:38:36 PDT 
Created attachment 424733 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-03-30 21:56:45 PDT 
Created attachment 424734 [details]
Patch
Comment 3 Sam Weinig 2021-03-31 11:24:29 PDT 
Comment on attachment 424734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424734&action=review

> Source/WebCore/page/Chrome.cpp:549
> +void Chrome::windowScreenDidChange(PlatformDisplayID displayID, Optional<FramesPerSecond> nominalFrameInterval)

Seems like at some point we should add a "PlatformDisplay" or "PlatformScreen" object that can package these.

> Source/WebCore/page/Page.cpp:1186
> +        // If the caller didn't give us a refresh rate, maybe the relevant DisplayRefreshMonitor can? This happens in WebKitLegacy.

Can you add a little bit more detail about why this can happen in WebKitLegacy?
Comment 4 Simon Fraser (smfr) 2021-03-31 13:59:57 PDT 
https://trac.webkit.org/changeset/275302/webkit
Comment 5 Radar WebKit Bug Importer 2021-03-31 14:00:19 PDT 
<rdar://problem/76069665>