Bug 223983 - `font-size: 0` text takes up space when using the complex text layout path
Summary: `font-size: 0` text takes up space when using the complex text layout path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-30 21:27 PDT by Cameron McCormack (:heycam)
Modified: 2021-03-31 17:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.94 KB, patch)
2021-03-30 22:08 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff
Patch (3.12 KB, patch)
2021-03-31 15:32 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-03-30 21:27:42 PDT
At least on macOS, when we use the complex text layout path, then InlineTextBoxes for text at `font-size: 0` still take up space.
Comment 1 Cameron McCormack (:heycam) 2021-03-30 21:28:04 PDT
<rdar://71157257>
Comment 2 Cameron McCormack (:heycam) 2021-03-30 22:08:40 PDT
Created attachment 424736 [details]
Patch
Comment 3 Cameron McCormack (:heycam) 2021-03-31 15:29:47 PDT
Comment on attachment 424736 [details]
Patch

Er I should write a proper ChangeLog first.
Comment 4 Cameron McCormack (:heycam) 2021-03-31 15:32:49 PDT
Created attachment 424831 [details]
Patch
Comment 5 EWS 2021-03-31 17:33:35 PDT
Committed r275326: <https://commits.webkit.org/r275326>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424831 [details].