Bug 22396 - [Gtk] Creation of Inspector WebView is unusable in Python
Summary: [Gtk] Creation of Inspector WebView is unusable in Python
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-11-21 00:11 PST by Jan Alonzo
Modified: 2008-11-21 03:41 PST (History)
0 users

See Also:


Attachments
Make the Inspector WebView creation usable in Python - API improvement (5.99 KB, patch)
2008-11-21 00:15 PST, Jan Alonzo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2008-11-21 00:11:41 PST
Currently we rely on ::inspect-web-view event to have the inspector WebView and the inspector window created by the client application. The problem is that the client then needs to pass the WebView back to WebKit through the signal handler's return value. This is not going to work, and let alone intuitive, in python.

I propose (patch coming up) to redesign ::inspect-web-view. Instead of allowing the client application to create the WebView, WebKit will just create it and send a ::prepare-window event to get the application to prepare the container of the Inspector WebView.

My rationale for this changes are:

1. So the python webkit/gtk bindings project can have a usable WebInspector API.

2. Allowing the client application to create a WebView then pass it back is, in my opinion, an extra unnecessary step. The client can still get to the Inspector WebView through webkit_web_inspector_get_view anyway. 

3. ::prepare-window is more inline with the rest of the events (::show-window, attach-window, etc..)

Thanks,
Comment 1 Jan Alonzo 2008-11-21 00:15:20 PST
Created attachment 25342 [details]
Make the Inspector WebView creation usable in Python - API improvement
Comment 2 Jan Alonzo 2008-11-21 03:33:26 PST
Comment on attachment 25342 [details]
Make the Inspector WebView creation usable in Python - API improvement

Setting to None as I seemed to misunderstood the issue here.