Bug 223959 – Add Options::exitOnResourceExhaustion() to enable exiting instead of crashing on resource exhaustion.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

This is useful to unblock fuzzers from false positive crashes due to resource exhaustion.

rdar://63934158

[Mark Lam]

Created attachment 424704 [details]
proposed patch.

[Tadeu Zagallo]

Comment on attachment 424704 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=424704&action=review

r=me

> Source/JavaScriptCore/runtime/ResourceExhaustion.cpp:36
> +    WTFReportAssertionFailureWithMessage(file, line, function, assertion, "ResourceExhaustion(%d): %s", static_cast<int>(exitCode), failureMessage);

Since this isn't called directly, you could use the macro to stringify the ResourceExhaustionCode.

[Mark Lam]

Comment on attachment 424704 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=424704&action=review

Thanks for the review.

>> Source/JavaScriptCore/runtime/ResourceExhaustion.cpp:36
>> +    WTFReportAssertionFailureWithMessage(file, line, function, assertion, "ResourceExhaustion(%d): %s", static_cast<int>(exitCode), failureMessage);
> 
> Since this isn't called directly, you could use the macro to stringify the ResourceExhaustionCode.

I had debated back and forth on whether I should do this initially.  I think I'll go with adding the stringified code.

[Mark Lam]

Landed in r275243: <http://trac.webkit.org/r275243>.