Bug 223958 - Web Inspector: [Cocoa] WKInspectorResourceURLSchemeHandler can exceed the soft thread limit when opening multiple inspectors simultaneously.
Summary: Web Inspector: [Cocoa] WKInspectorResourceURLSchemeHandler can exceed the sof...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-30 14:41 PDT by Patrick Angle
Modified: 2021-03-31 19:31 PDT (History)
7 users (show)

See Also:

Attachments
Patch v1.0 (2.65 KB, patch)
2021-03-30 14:51 PDT, Patrick Angle 		no flags Details | Formatted Diff | Diff
Patch v1.1 - Shorten redundant part of comment (2.54 KB, patch)
2021-03-31 19:02 PDT, Patrick Angle 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-03-30 14:41:57 PDT 
Multiple WKInspectorResourceURLSchemeHandlers may be loading inspectors at the same time, which makes it possible for their combined operations to exceed the soft thread limit. In practice, this should only possible in engineering builds.
Comment 1 Patrick Angle 2021-03-30 14:47:25 PDT 
<rdar://75847924>
Comment 2 Patrick Angle 2021-03-30 14:51:36 PDT 
Created attachment 424701 [details]
Patch v1.0
Comment 3 BJ Burg 2021-03-31 15:30:28 PDT 
Comment on attachment 424701 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=424701&action=review

r=me

> Source/WebKit/UIProcess/Inspector/mac/WKInspectorResourceURLSchemeHandler.mm:62
> +        // The default value (NSOperationQueueDefaultMaxConcurrentOperationCount) results in a large number of threads

I think this second comment is nice but redundant with the changelog, and could be removed.
Comment 4 Patrick Angle 2021-03-31 19:02:21 PDT 
Created attachment 424862 [details]
Patch v1.1 - Shorten redundant part of comment
Comment 5 EWS 2021-03-31 19:31:23 PDT 
Committed r275341: <https://commits.webkit.org/r275341>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424862 [details].