Bug 223943 - [macOS] Reduce logging for uninteresting sandbox violations
Summary: [macOS] Reduce logging for uninteresting sandbox violations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-30 11:41 PDT by Brent Fulgham
Modified: 2021-04-29 10:45 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.11 KB, patch)
2021-03-30 11:47 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (3.14 KB, patch)
2021-03-30 11:50 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch for landing (3.10 KB, patch)
2021-03-30 14:28 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-03-30 11:41:59 PDT
During testing, we have found a few IOKit properties needed by the macOS Network Process, and a handful of items needed when running in recovery mode. We should unblock these items to allow proper function and to reduce telemetry for items that we don't need to learn more about.
Comment 1 Radar WebKit Bug Importer 2021-03-30 11:45:27 PDT
<rdar://problem/76014115>
Comment 2 Brent Fulgham 2021-03-30 11:47:57 PDT
Created attachment 424669 [details]
Patch
Comment 3 Brent Fulgham 2021-03-30 11:50:36 PDT
Created attachment 424670 [details]
Patch
Comment 4 Per Arne Vollan 2021-03-30 14:16:22 PDT
Comment on attachment 424670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424670&action=review

R=me.

> Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:305
> +    (global-name "com.apple.DiskArbitration.diskarbitrationd")

I think it would be good if we could avoid adding this. One option is to filter with uid == 0.
Comment 5 Brent Fulgham 2021-03-30 14:26:37 PDT
Comment on attachment 424670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424670&action=review

>> Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:305
>> +    (global-name "com.apple.DiskArbitration.diskarbitrationd")
> 
> I think it would be good if we could avoid adding this. One option is to filter with uid == 0.

I'll add it to the uid==0 case, but I think it actually makes sense for Network to interact with disk.
Comment 6 Brent Fulgham 2021-03-30 14:28:36 PDT
Created attachment 424698 [details]
Patch for landing
Comment 7 EWS 2021-03-30 15:25:35 PDT
Committed r275242: <https://commits.webkit.org/r275242>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424698 [details].