Bug 223942 – Add confirmation prompt to discourage manual commits

• Status: ASSIGNED
• Component: Tools / Tests

[Aakash Jain]

Add a confirmation prompt which appears while doing manual committing (e.g.: through webkit-patch land) to discourage manual commits. Manual commits will not be allowed after we move to github. So, it would be good to provide such warning so that people can either start using commit-queue, or let us know the reason for manual commits, so that commit-queue can be improved.

[Aakash Jain]

Created attachment 424672 [details]
Patch

[Aakash Jain]

unit-tests needs to be updated, but would be nice to have it reviewed meanwhile.

[Jonathan Bedard]

Comment on attachment 424672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424672&action=review

Looks good, just need to update the unit tests.

> Tools/Scripts/webkitpy/tool/steps/commit.py:72
> +        warning_message += '\nIn future, when WebKit moves to github, manual commiting would not be allowed.'

github -> GitHub

[Sam Weinig]

Comment on attachment 424672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424672&action=review

> Tools/Scripts/webkitpy/tool/steps/commit.py:74
> +        warning_message += '\nIn you have a specific reason for manual commit, please let us know at [e-mail] or please file a bug.'
> +        warning_message += '\nAre you sure you want to continue with manual committing?'

Manual committing is very useful for quick typo fixes and build fixes. This doesn't seem like a great new rule to push on the community, especially if we don't have big problem with it.

[Jonathan Bedard]

(In reply to Sam Weinig from comment #4)
> Comment on attachment 424672 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424672&action=review
> 
> > Tools/Scripts/webkitpy/tool/steps/commit.py:74
> > +        warning_message += '\nIn you have a specific reason for manual commit, please let us know at [e-mail] or please file a bug.'
> > +        warning_message += '\nAre you sure you want to continue with manual committing?'
> 
> Manual committing is very useful for quick typo fixes and build fixes. This
> doesn't seem like a great new rule to push on the community, especially if
> we don't have big problem with it.

We don't have a great way to do any pre-commit validation in GitHub the way we do in Subversion. This is important for things like enforcing rules with tabs, adding identifiers to commit messages, rejecting changes with "OOPS" in them.

To address build-fix/type style changes, the plan is to have a fast-path commit-queue that works the way current commit queue does when EWS was successful.

[Aakash Jain]

> To address build-fix/type style changes, the plan is to have a fast-path commit-queue that works the way current commit queue does when EWS was successful.
Note that the fast-commit-queue will also skip Building. It should take it only ~1 minute to land the patch. We just add the fast-commit-queue mode in https://bugs.webkit.org/show_bug.cgi?id=223954. We also plan to add webkit-patch support for it (e.g.: using --fast-cq parameter).

[Radar WebKit Bug Importer]

<rdar://problem/76276805>