Bug 223928 - Optimize createListFromArrayLike() and Proxy's [[OwnPropertyKeys]] method
Summary: Optimize createListFromArrayLike() and Proxy's [[OwnPropertyKeys]] method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-30 07:02 PDT by Alexey Shvayka
Modified: 2021-04-01 09:08 PDT (History)
12 users (show)

See Also:


Attachments
Patch (17.91 KB, patch)
2021-03-30 07:05 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff
Patch (19.52 KB, patch)
2021-03-30 13:47 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff
Patch (18.57 KB, patch)
2021-03-30 16:34 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-03-30 07:02:19 PDT
Optimize createListFromArrayLike() and Proxy's [[OwnPropertyKeys]] method
Comment 1 Alexey Shvayka 2021-03-30 07:05:19 PDT
Created attachment 424635 [details]
Patch
Comment 2 Alexey Shvayka 2021-03-30 07:05:59 PDT
(In reply to Alexey Shvayka from comment #1)
> Created attachment 424635 [details]
> Patch

                                    r274349                   patch

reflect-own-keys-proxy         69.1157+-1.3454     ^     53.2344+-0.8644        ^ definitely 1.2983x faster
reflect-own-keys-proxy-2       75.4748+-0.8499     ^     62.5830+-0.8780        ^ definitely 1.2060x faster

<geometric>                    72.2098+-0.9571     ^     57.7050+-0.6808        ^ definitely 1.2514x faster
Comment 3 Alexey Shvayka 2021-03-30 13:47:41 PDT
Created attachment 424689 [details]
Patch

Make JSArrayInlines.h a private header to fix WebCore build.
Comment 4 Alexey Shvayka 2021-03-30 16:34:55 PDT
Created attachment 424714 [details]
Patch

Add JSArrayInlines.h to CMakeLists.txt and remove uint32_t getIndex() override.
Comment 5 Yusuke Suzuki 2021-04-01 00:40:54 PDT
Comment on attachment 424714 [details]
Patch

r=me
Comment 6 EWS 2021-04-01 09:07:15 PDT
Committed r275363: <https://commits.webkit.org/r275363>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424714 [details].
Comment 7 Radar WebKit Bug Importer 2021-04-01 09:08:16 PDT
<rdar://problem/76106345>