Bug 223925 – Crash in conformance2/textures/misc/compressed-tex-image.html with ANGLE+METAL

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[Kimmo Kinnunen]

Opened with mini browser:
file:///Users/kkinnunen/WebKit/OpenSource/LayoutTests//webgl/resources/webgl_test_files/conformance2/textures/misc/compressed-tex-image.html?webglVersion=2

Thread 1 Queue : com.apple.main-thread (serial)
#0	0x000000082db411de in gl::LogMessage::~LogMessage() at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/common/debug.cpp:199
#1	0x000000082db40ab5 in gl::LogMessage::~LogMessage() at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/common/debug.cpp:175
#2	0x000000082e20c05f in rx::TextureMtl::convertAndSetPerSliceSubImage(gl::Context const*, int, MTLRegion const&, gl::InternalFormat const&, unsigned int, angle::Format const&, unsigned long, unsigned long, gl::Buffer*, unsigned char const*, std::__1::shared_ptr<rx::mtl::Texture> const&) at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm:1749
#3	0x000000082e20b9ca in rx::TextureMtl::convertAndSetPerSliceSubImage(gl::Context const*, int, MTLRegion const&, gl::InternalFormat const&, unsigned int, angle::Format const&, unsigned long, unsigned long, gl::Buffer*, unsigned char const*, std::__1::shared_ptr<rx::mtl::Texture> const&) at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm:1709
#4	0x000000082e20b1ce in rx::TextureMtl::setPerSliceSubImage(gl::Context const*, int, MTLRegion const&, gl::InternalFormat const&, unsigned int, angle::Format const&, unsigned long, unsigned long, gl::Buffer*, unsigned char const*, std::__1::shared_ptr<rx::mtl::Texture> const&) at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm:1641
#5	0x000000082e206640 in rx::TextureMtl::setSubImageImpl(gl::Context const*, gl::ImageIndex const&, gl::Box const&, gl::InternalFormat const&, unsigned int, gl::PixelUnpackState const&, gl::Buffer*, unsigned char const*) at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm:1598
#6	0x000000082e205fc3 in rx::TextureMtl::setImageImpl(gl::Context const*, gl::ImageIndex const&, gl::InternalFormat const&, gl::Extents const&, unsigned int, unsigned int, gl::PixelUnpackState const&, gl::Buffer*, unsigned char const*) at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm:1514
#7	0x000000082e206751 in rx::TextureMtl::setCompressedImage(gl::Context const*, gl::ImageIndex const&, unsigned int, gl::Extents const&, gl::PixelUnpackState const&, unsigned long, unsigned char const*) at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm:919
#8	0x000000082e1e11db in gl::Texture::setCompressedImage(gl::Context*, gl::PixelUnpackState const&, gl::TextureTarget, int, unsigned int, gl::Extents const&, unsigned long, unsigned char const*) at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/libANGLE/Texture.cpp:1198
#9	0x000000082daa6a0e in gl::Context::compressedTexImage2D(gl::TextureTarget, int, unsigned int, int, int, int, int, void const*) at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp:4616
#10	0x000000082daa6abc in gl::Context::compressedTexImage2DRobust(gl::TextureTarget, int, unsigned int, int, int, int, int, int, void const*) at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp:4631
#11	0x000000082dc198a5 in gl::CompressedTexImage2DRobustANGLE(unsigned int, int, unsigned int, int, int, int, int, int, void const*) at /Users/kkinnunen/WebKit/OpenSource/Source/ThirdParty/ANGLE/src/libGLESv2/entry_points_gles_ext_autogen.cpp:1807
#12	0x0000000808d61e77 in WebCore::GraphicsContextGLOpenGL::compressedTexImage2D(unsigned int, int, unsigned int, int, int, int, int, GCGLSpan<void const, 18446744073709551615ul>) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:326
#13	0x0000000808d61faf in WebCore::GraphicsContextGLOpenGL::compressedTexImage2D(unsigned int, int, unsigned int, int, int, int, int, long) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:332
#14	0x000000080c00c426 in WebCore::WebGL2RenderingContext::compressedTexImage2D(unsigned int, int, unsigned int, int, int, int, int, long long) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1365
#15	0x000000080a1e32dc in WebCore::jsWebGL2RenderingContextPrototypeFunction_compressedTexImage2D1Body(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSWebGL2RenderingContext*)::'lambda'()::operator()() const at /Users/kkinnunen/Build/Debug/DerivedSources/WebCore/JSWebGL2RenderingContext.cpp:8253
#16	0x000000080a1e31ed in JSC::JSValue WebCore::toJS<WebCore::IDLUndefined, WebCore::jsWebGL2RenderingContextPrototypeFunction_compressedTexImage2D1Body(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSWebGL2RenderingContext*)::'lambda'()>(JSC::JSGlobalObject&, JSC::ThrowScope&, WebCore::jsWebGL2RenderingContextPrototypeFunction_compressedTexImage2D1Body(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSWebGL2RenderingContext*)::'lambda'()&&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/bindings/js/JSDOMConvertBase.h:165
#17	0x000000080a1e2981 in WebCore::jsWebGL2RenderingContextPrototypeFunction_compressedTexImage2D1Body(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSWebGL2RenderingContext*) at /Users/kkinnunen/Build/Debug/DerivedSources/WebCore/JSWebGL2RenderingContext.cpp:8253
#18	0x000000080a1e0977 in WebCore::jsWebGL2RenderingContextPrototypeFunction_compressedTexImage2DOverloadDispatcher(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSWebGL2RenderingContext*) at /Users/kkinnunen/Build/Debug/DerivedSources/WebCore/JSWebGL2RenderingContext.cpp:9697
#19	0x000000080a1e076c in long long WebCore::IDLOperation<WebCore::JSWebGL2RenderingContext>::call<&(WebCore::jsWebGL2RenderingContextPrototypeFunction_compressedTexImage2DOverloadDispatcher(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSWebGL2RenderingContext*)), (WebCore::CastedThisErrorBehavior)0>(JSC::JSGlobalObject&, JSC::CallFrame&, char const*) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/bindings/js/JSDOMOperation.h:55
#20	0x000000080a169ea4 in WebCore::jsWebGL2RenderingContextPrototypeFunction_compressedTexImage2D(JSC::JSGlobalObject*, JSC::CallFrame*) at /Users/kkinnunen/Build/Debug/DerivedSources/WebCore/JSWebGL2RenderingContext.cpp:9708
#21	0x000041c0794011d8 in 0x41c0794011d8 ()
#22	0x0000000826777a45 in llint_entry at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:1093
#23	0x0000000826755a10 in vmEntryToJavaScript at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:316
#24	0x0000000827618e3b in JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/jit/JITCodeInlines.h:42
#25	0x000000082761481a in JSC::Interpreter::execute(JSC::EvalExecutable*, JSC::JSGlobalObject*, JSC::JSValue, JSC::JSScope*) at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/interpreter/Interpreter.cpp:1201
#26	0x0000000827612cc4 in JSC::eval(JSC::JSGlobalObject*, JSC::CallFrame*, JSC::ECMAMode) at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/interpreter/Interpreter.cpp:161
#27	0x0000000827760bc3 in JSC::LLInt::commonCallEval(JSC::CallFrame*, JSC::Instruction const*, JSC::MacroAssemblerCodeRef<(WTF::PtrTag)357>) at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:2040
#28	0x00000008277608f8 in ::llint_slow_path_call_eval(JSC::CallFrame *, const JSC::Instruction *) at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:2047
#29	0x0000000826779d12 in llint_entry at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:97
#30	0x0000000826777a45 in llint_entry at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:1093
#31	0x0000000826777a45 in llint_entry at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:1093
#32	0x0000000826755a10 in vmEntryToJavaScript at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:316
#33	0x0000000827618e3b in JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/jit/JITCodeInlines.h:42
#34	0x0000000827618398 in JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*) at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/interpreter/Interpreter.cpp:839
#35	0x00000008279f6b17 in JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/runtime/Completion.cpp:137
#36	0x00000008279f6c6a in JSC::profiledEvaluate(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) at /Users/kkinnunen/WebKit/OpenSource/Source/JavaScriptCore/runtime/Completion.cpp:152
#37	0x000000080b3e5ebc in WebCore::JSExecState::profiledEvaluate(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/bindings/js/JSExecState.h:79
#38	0x000000080b3e5a9e in WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/bindings/js/ScriptController.cpp:148
#39	0x000000080b3e58c9 in WebCore::ScriptController::evaluateInWorldIgnoringException(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/bindings/js/ScriptController.cpp:121
#40	0x000000080b3e61c5 in WebCore::ScriptController::evaluateIgnoringException(WebCore::ScriptSourceCode const&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/bindings/js/ScriptController.cpp:167
#41	0x000000080bb42b76 in WebCore::ScriptElement::executeClassicScript(WebCore::ScriptSourceCode const&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/dom/ScriptElement.cpp:405
#42	0x000000080baac110 in WebCore::LoadableClassicScript::execute(WebCore::ScriptElement&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/dom/LoadableClassicScript.cpp:123
#43	0x000000080bb4381a in WebCore::ScriptElement::executeScriptAndDispatchEvent(WebCore::LoadableScript&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/dom/ScriptElement.cpp:447
#44	0x000000080bb43966 in WebCore::ScriptElement::executePendingScript(WebCore::PendingScript&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/dom/ScriptElement.cpp:455
#45	0x000000080c0d5916 in WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent(WebCore::PendingScript&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/html/parser/HTMLScriptRunner.cpp:114
#46	0x000000080c0d60c0 in WebCore::HTMLScriptRunner::executeParsingBlockingScripts() at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/html/parser/HTMLScriptRunner.cpp:164
#47	0x000000080c0d6301 in WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad(WebCore::PendingScript&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/html/parser/HTMLScriptRunner.cpp:174
#48	0x000000080c0b5d5f in WebCore::HTMLDocumentParser::notifyFinished(WebCore::PendingScript&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/html/parser/HTMLDocumentParser.cpp:589
#49	0x000000080bb112b3 in WebCore::PendingScript::notifyClientFinished() at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/dom/PendingScript.cpp:69
#50	0x000000080bb11319 in WebCore::PendingScript::notifyFinished(WebCore::LoadableScript&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/dom/PendingScript.cpp:74
#51	0x000000080baabf91 in WebCore::LoadableScript::notifyClientFinished() at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/dom/LoadableScript.cpp:60
#52	0x000000080baabd81 in WebCore::LoadableClassicScript::notifyFinished(WebCore::CachedResource&, WebCore::NetworkLoadMetrics const&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/dom/LoadableClassicScript.cpp:117
#53	0x000000080c6377ba in WebCore::CachedResource::checkNotify(WebCore::NetworkLoadMetrics const&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/loader/cache/CachedResource.cpp:379
#54	0x000000080c6332ac in WebCore::CachedResource::finishLoading(WebCore::SharedBuffer*, WebCore::NetworkLoadMetrics const&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/loader/cache/CachedResource.cpp:395
#55	0x000000080c66f107 in WebCore::CachedScript::finishLoading(WebCore::SharedBuffer*, WebCore::NetworkLoadMetrics const&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/loader/cache/CachedScript.cpp:103
#56	0x000000080c5badb4 in WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebCore/loader/SubresourceLoader.cpp:736
#57	0x00000007f9d7d64a in WebKit::WebResourceLoader::didFinishResourceLoad(WebCore::NetworkLoadMetrics const&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:227
#58	0x00000007fa378e30 in void IPC::callMemberFunctionImpl<WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&), std::__1::tuple<WebCore::NetworkLoadMetrics>, 0ul>(WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&), std::__1::tuple<WebCore::NetworkLoadMetrics>&&, std::__1::integer_sequence<unsigned long, 0ul>) at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/Platform/IPC/HandleMessage.h:43
#59	0x00000007fa378d80 in void IPC::callMemberFunction<WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&), std::__1::tuple<WebCore::NetworkLoadMetrics>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WebCore::NetworkLoadMetrics>&&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)) at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/Platform/IPC/HandleMessage.h:49
#60	0x00000007fa376b2e in void IPC::handleMessage<Messages::WebResourceLoader::DidFinishResourceLoad, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)>(IPC::Decoder&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)) at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/Platform/IPC/HandleMessage.h:121
#61	0x00000007fa37649e in WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage(IPC::Connection&, IPC::Decoder&) at /Users/kkinnunen/Build/Debug/DerivedSources/WebKit2/WebResourceLoaderMessageReceiver.cpp:56
#62	0x00000007f9d3e930 in WebKit::NetworkProcessConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:94
#63	0x00000007f8084024 in IPC::Connection::dispatchMessage(IPC::Decoder&) at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/Platform/IPC/Connection.cpp:1020
#64	0x00000007f80847ec in IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/Platform/IPC/Connection.cpp:1065
#65	0x00000007f8084e10 in IPC::Connection::dispatchOneIncomingMessage() at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/Platform/IPC/Connection.cpp:1134
#66	0x00000007f80a3368 in IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_9::operator()() at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/Platform/IPC/Connection.cpp:989
#67	0x00000007f80a325e in WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_9, void>::call() at /Users/kkinnunen/Build/Debug/usr/local/include/wtf/Function.h:52
#68	0x00000008261aec62 in WTF::Function<void ()>::operator()() const at /Users/kkinnunen/Build/Debug/usr/local/include/wtf/Function.h:83
#69	0x0000000826226de5 in WTF::RunLoop::performWork() at /Users/kkinnunen/WebKit/OpenSource/Source/WTF/wtf/RunLoop.cpp:133
#70	0x000000082622a761 in WTF::RunLoop::performWork(void*) at /Users/kkinnunen/WebKit/OpenSource/Source/WTF/wtf/cf/RunLoopCF.cpp:46
#71	0x00007fff2045be2c in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ ()
#72	0x00007fff2045bd94 in __CFRunLoopDoSource0 ()
#73	0x00007fff2045bb14 in __CFRunLoopDoSources0 ()
#74	0x00007fff2045a53c in __CFRunLoopRun ()
#75	0x00007fff20459afc in CFRunLoopRunSpecific ()
#76	0x00007fff211e3bb7 in -[NSRunLoop(NSRunLoop) runMode:beforeDate:] ()
#77	0x00007fff21271a81 in -[NSRunLoop(NSRunLoop) run] ()
#78	0x00007fff200b138d in _xpc_objc_main ()
#79	0x00007fff200b0cd3 in xpc_main ()
#80	0x00000007f8d628e1 in WebKit::XPCServiceMain(int, char const**) at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:209
#81	0x00000007fa404c6b in WKXPCServiceMain at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/Shared/API/Cocoa/WKMain.mm:33
#82	0x000000010c597ea2 in main at /Users/kkinnunen/WebKit/OpenSource/Source/WebKit/Shared/EntryPointUtilities/Cocoa/AuxiliaryProcessMain.cpp:30

[Kyle Piddington]

Created attachment 424847 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Radar WebKit Bug Importer]

<rdar://problem/76262928>

[EWS]

Committed r275649: <https://commits.webkit.org/r275649>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424847 [details].