Bug 223924 - Fix interpolation of box-shadow and text-shadow CSS properties
Summary: Fix interpolation of box-shadow and text-shadow CSS properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-30 04:52 PDT by Antoine Quint
Modified: 2021-03-31 00:45 PDT (History)
4 users (show)

See Also:


Attachments
Patch (70.11 KB, patch)
2021-03-30 04:56 PDT, Antoine Quint
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-03-30 04:52:48 PDT
Fix interpolation of box-shadow and text-shadow CSS properties
Comment 1 Antoine Quint 2021-03-30 04:56:30 PDT
Created attachment 424629 [details]
Patch
Comment 2 Dean Jackson 2021-03-30 12:42:19 PDT
Comment on attachment 424629 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424629&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:141
> +        radius < 0 ? 0 : radius,

std::max(0, radius)?
Comment 3 Antoine Quint 2021-03-31 00:39:49 PDT
(In reply to Dean Jackson from comment #2)
> Comment on attachment 424629 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424629&action=review
> 
> > Source/WebCore/animation/CSSPropertyAnimation.cpp:141
> > +        radius < 0 ? 0 : radius,
> 
> std::max(0, radius)?

Will fix in commit.
Comment 4 Antoine Quint 2021-03-31 00:44:30 PDT
Committed r275272 (235957@main): <https://commits.webkit.org/235957@main>
Comment 5 Radar WebKit Bug Importer 2021-03-31 00:45:19 PDT
<rdar://problem/76042311>